all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: 17397@debbugs.gnu.org
Subject: bug#17397: 24.4.50; REGRESSION: `temp-buffer-show-hook' is no longer invoked for `describe-variable'
Date: Tue, 13 May 2014 14:24:43 -0700 (PDT)	[thread overview]
Message-ID: <c19063d7-2b3a-43c9-9393-a84ad80b250d@default> (raw)
In-Reply-To: <18354a80-fa76-43bd-a06b-7d2c4ccbbfd4@default>

I would really like to get some help with this. So far, no
response at all.

Help functions using buffer *Help* previously used
`with-output-to-temp-buffer', which runs `temp-buffer-setup-hook'
and `temp-buffer-show-hook'.  And previously the setup hook
usually put the buffer in help mode.

Now, *Help* is set up by `with-help-window', and neither of those
hooks is run by it.  This is a regression, to me - any code or any
user who relies on those hooks being run for *Help* buffers is up
the creek without a paddle, AFAICS.

So be it.  But what is that code or that user supposed to do now?

`with-help-window' invokes `with-temp-buffer-window', which runs
`temp-buffer-window-setup-hook' and `temp-buffer-window-show-hook'.

To get *Help* to DTRT for the code or user that previously used
`temp-buffer-setup-hook' or `temp-buffer-show-hook, is it
appropriate to put the same things on `temp-buffer-window-setup-hook'
and `temp-buffer-window-show-hook' instead?  Or will that maybe
have unwanted effects because `with-temp-buffer-window' is perhaps
used for more than just *Help*?

Not clear to me.  And I find no help in the doc or NEWS - or in
this bug thread, so far.

Should I be adding `fit-frame-if-one-window' to `temp-buffer-window'
for Emacs 24.4, to get the effect it has in Emacs 24.3 (and prior)
by being on `temp-buffer-show-hook'?

If not, how to get the same effect?  If yes, how to deal with other
possible uses of `with-temp-buffer-window', which have nothing to do
with *Help*?  (In the case of `fit-frame-if-one-window', that would
probably not hurt anything, but the question is more general.)

--

The existing doc is anyway wrong in some cases, AFAICT: The doc
string of `with-temp-buffer-window' says:

  This construct is similar to `with-output-to-temp-buffer'
  but, neither runs `temp-buffer-setup-hook' which usually puts
  the buffer in Help mode, nor `temp-buffer-show-function' (the
  ACTION argument replaces this).

And the doc string of `temp-buffer-setup-hook', likewise, says:

  This hook is normally set up with a function to put the buffer
  in Help mode.

I don't get the impression that either of those statements is
true anymore.  It seems like there is *no relation* anymore
between such temp-buffer things and Help mode.  Furthermore,
grepping for `temp-buffer-setup-hook' in the Emacs sources
shows that it is not used for this at all anymore.

A little help, please.





  parent reply	other threads:[~2014-05-13 21:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-03 21:32 bug#17397: 24.4.50; REGRESSION: `temp-buffer-show-hook' is no longer invoked for `describe-variable' Drew Adams
2014-05-03 21:41 ` Drew Adams
2014-05-13 21:24 ` Drew Adams [this message]
2014-05-14  7:06   ` martin rudalics
2014-05-14 16:25     ` Drew Adams
2014-05-14 17:33       ` martin rudalics
2014-05-14 18:41         ` Drew Adams
2014-05-15  7:50           ` martin rudalics
2014-05-15 14:02             ` Drew Adams
2014-05-16  6:22               ` martin rudalics
2021-10-10 23:01             ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c19063d7-2b3a-43c9-9393-a84ad80b250d@default \
    --to=drew.adams@oracle.com \
    --cc=17397@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.