On 1/18/2023 11:37 PM, Jim Porter wrote: > On 1/18/2023 10:49 PM, Eli Zaretskii wrote: >> Why do you remove a non-internal function?  We cannot possibly do that >> if this is going to be installed on the emacs-29 branch.  But even if >> you are going to install on master, why not leave that function alone? >> Some code somewhere could be using it, and we don't usually remove >> functions before a period of deprecation. > > I can keep 'eshell-eval-indices' around and mark it obsolete if you > prefer; it wouldn't hurt anything. Here's a patch that does this. It doesn't try to fix 'eshell-eval-indices', since people shouldn't use that anyway. (I also renamed the new 'eshell-indices' to 'eshell-prepare-indices' to be clearer.)