* bug#9817: 24.0.90; tar-mode: wrong display of suid and sgid bits
@ 2011-10-20 22:37 Ulrich Mueller
2011-10-21 6:44 ` Glenn Morris
0 siblings, 1 reply; 2+ messages in thread
From: Ulrich Mueller @ 2011-10-20 22:37 UTC (permalink / raw)
To: 9817
In the display of file modes in tar-mode's listing, the suid and sgid
bits are interchanged.
The following session illustrates the problem:
$ touch foo bar
$ chmod u+s foo
$ chmod g+s bar
$ ls -fl foo bar
-rwSr--r-- 1 ulm users 0 Oct 20 23:22 foo
-rw-r-Sr-- 1 ulm users 0 Oct 20 23:22 bar
$ tar cf foo.tar foo bar
$ tar tvf foo.tar
-rwSr--r-- ulm/users 0 2011-10-20 23:22 foo
-rw-r-Sr-- ulm/users 0 2011-10-20 23:22 bar
$ emacs -Q foo.tar
Now, in tar-mode's listing the two flags are interchanged:
-rw-r-sr-- ulm/users 0 foo
-rwsr--r-- ulm/users 0 bar
Also, they should be displayed with a capital letter S if the
corresponding executable bit is not set, and the sticky bit should
be shown, too. The patch included below fixes the problem for me.
2011-10-20 Ulrich Mueller <ulm@gentoo.org>
* tar-mode.el (tar-grind-file-mode): Display suid and sgid flags
correctly.
@@ -404,13 +404,19 @@
(string
(if (zerop (logand 256 mode)) ?- ?r)
(if (zerop (logand 128 mode)) ?- ?w)
- (if (zerop (logand 1024 mode)) (if (zerop (logand 64 mode)) ?- ?x) ?s)
+ (if (zerop (logand 2048 mode))
+ (if (zerop (logand 64 mode)) ?- ?x)
+ (if (zerop (logand 64 mode)) ?S ?s))
(if (zerop (logand 32 mode)) ?- ?r)
(if (zerop (logand 16 mode)) ?- ?w)
- (if (zerop (logand 2048 mode)) (if (zerop (logand 8 mode)) ?- ?x) ?s)
+ (if (zerop (logand 1024 mode))
+ (if (zerop (logand 8 mode)) ?- ?x)
+ (if (zerop (logand 8 mode)) ?S ?s))
(if (zerop (logand 4 mode)) ?- ?r)
(if (zerop (logand 2 mode)) ?- ?w)
- (if (zerop (logand 1 mode)) ?- ?x)))
+ (if (zerop (logand 512 mode))
+ (if (zerop (logand 1 mode)) ?- ?x)
+ (if (zerop (logand 1 mode)) ?T ?t))))
(defun tar-header-block-summarize (tar-hblock &optional mod-p)
"Return a line similar to the output of `tar -vtf'."
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#9817: 24.0.90; tar-mode: wrong display of suid and sgid bits
2011-10-20 22:37 bug#9817: 24.0.90; tar-mode: wrong display of suid and sgid bits Ulrich Mueller
@ 2011-10-21 6:44 ` Glenn Morris
0 siblings, 0 replies; 2+ messages in thread
From: Glenn Morris @ 2011-10-21 6:44 UTC (permalink / raw)
To: 9817-done
Version: 24.0.91
Thanks; applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-21 6:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-20 22:37 bug#9817: 24.0.90; tar-mode: wrong display of suid and sgid bits Ulrich Mueller
2011-10-21 6:44 ` Glenn Morris
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.