From: Paul Eggert <eggert@cs.ucla.edu>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
emacs-devel@gnu.org, monnier@iro.umontreal.ca, oleh@oremacs.com
Subject: Re: [Emacs-diffs] emacs-26 3db388b: Speed up (format "%s" STRING) and the like
Date: Fri, 6 Oct 2017 11:06:20 -0700 [thread overview]
Message-ID: <c0bc5a69-ff56-8242-be95-3e6694e2d031@cs.ucla.edu> (raw)
In-Reply-To: <CAFyQvY1wbKPjt9MUnMTcM2zNE37OSn9MOWx8pU+nrHqrf_VY-A@mail.gmail.com>
On 10/06/2017 10:49 AM, Kaushal Modi wrote:
> what would be the simplest way to explain why it worked using the
> Makefile in hydra pkg, but not when installed via pacakge.el? Inspite
> of same (right?) .elc files?
The .elc files were not the same. However, I think that was a blind
alley, as .elc differences can be benign. The diagnostic was output only
when (format FOO) was called with a long FOO (greater than 235 chars,
roughly) without any % directives in it, and where the (format FOO) call
was either directly from bytecode or indirectly via channels that never
used unbind_to. The Makefile approach didn't byte-compile one of the
files that the package.el approach compiled, and I suspect that the
different path to (lv-message "long format with no % directives")
explained why I didn't reproduce the bug at first.
next prev parent reply other threads:[~2017-10-06 18:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171004214511.1405.22257@vcs0.savannah.gnu.org>
[not found] ` <20171004214513.6A40E2041C@vcs0.savannah.gnu.org>
2017-10-05 3:09 ` [Emacs-diffs] emacs-26 3db388b: Speed up (format "%s" STRING) and the like Stefan Monnier
2017-10-05 6:07 ` Paul Eggert
2017-10-05 7:30 ` Eli Zaretskii
2017-10-05 13:20 ` Stefan Monnier
2017-10-05 16:57 ` Kaushal Modi
2017-10-05 17:08 ` Kaushal Modi
2017-10-05 17:09 ` Kaushal Modi
2017-10-05 18:47 ` Eli Zaretskii
2017-10-05 20:13 ` Kaushal Modi
2017-10-05 21:44 ` Paul Eggert
2017-10-06 0:47 ` Kaushal Modi
2017-10-06 17:45 ` Paul Eggert
2017-10-06 17:49 ` Kaushal Modi
2017-10-06 18:06 ` Paul Eggert [this message]
2017-10-06 18:15 ` Kaushal Modi
2017-10-06 18:21 ` Kaushal Modi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0bc5a69-ff56-8242-be95-3e6694e2d031@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=kaushal.modi@gmail.com \
--cc=monnier@iro.umontreal.ca \
--cc=oleh@oremacs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.