From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: server.el test failures (was: Re: bug#9800: Incomplete truncated file buffers from the /proc filesystem) Date: Thu, 23 Feb 2023 18:20:39 -0800 Message-ID: References: <877h40vb8h.fsf@mail.jurta.org> <4EA4D31B.4050604@cs.ucla.edu> <4EA5E08D.8070903@cs.ucla.edu> <861qmvcglp.fsf@aarsen.me> <98e880a0-d076-cfd9-b39d-50c84fa8975a@gmail.com> <811d85e0-4032-68df-bc0c-1073ff5d1b96@cs.ucla.edu> <5a38c18d-263c-223b-7335-8395a10eb494@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------lDf1q6AtWIlmFOg4dms0bukL" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5838"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Feb 24 03:21:37 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pVNiL-000173-Ax for ged-emacs-devel@m.gmane-mx.org; Fri, 24 Feb 2023 03:21:37 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVNhV-000393-JU; Thu, 23 Feb 2023 21:20:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVNhU-00038K-Ih for emacs-devel@gnu.org; Thu, 23 Feb 2023 21:20:44 -0500 Original-Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVNhS-0003gt-Az for emacs-devel@gnu.org; Thu, 23 Feb 2023 21:20:44 -0500 Original-Received: by mail-pj1-x1031.google.com with SMTP id qi12-20020a17090b274c00b002341621377cso1342924pjb.2 for ; Thu, 23 Feb 2023 18:20:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=PfmgGKypRjf3O9iHsAl9RRVDJNE5XKavDcykOiWQdvU=; b=bkjlDuEVVRZ3cAd3IejocQJSsA7HcFkze1hse/jHgk2IZvj4oS+2uS6mM4nscnbtxS MV41jZ/+olhMExklRuwdfDzxTb/80bJtiv9sidmBAdPxPw14uTfXhB5bEBHdWQGu5S59 oFR7UHZvTPJ9jUahXZn77MoOIZIzTZb15wvLLBd8qm1UE2Jtq0fg0UQBE927ne32Oz++ Dxb/UbhNiY/Id6yirxF/m4NpOmu+9vIVd7a2Vbphown25F98lHR7JbykrQD2NRBr1Tpd OtblxekCaqeYGGSAjZ19WSAKIah/9c2AOylo9pqKqZNcTkg/dWZAl2ruYcxQjOzZKDB/ Hxcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=PfmgGKypRjf3O9iHsAl9RRVDJNE5XKavDcykOiWQdvU=; b=UFkPsV0n53/tvl5uXjbhEbhUOEKaouC/kOtBCEa1IQ0Qo/hIVl32IGKuPsfhS6srmH edc+h83RGKi0wxg6mQMsonapNsxoDY3CwaDKvHUDd33fj3FwluRhr03UH/9lz7BLFSiF 2PJgJBms9ihlsN83VCNzoavypFZAi8gdPObe8rGxEF9x2MDUQI95rVA4AMjv1hJktdxr BOkdGb+QfcWrK8y864CVD0++v4mMFErFgEENsNsaWFtlbmc3W75620n6gxKsm0Yw/+0Y eDt9BxL4F/UmeFp37n33ZvoHmen0S+Ff87R0TAIvfpHsh6+8KTwcOjTStLRDC1ZXHL5Y TsDg== X-Gm-Message-State: AO0yUKV6kPfQvceJiJ+c/Jtl4FmehoaV1zLp0h4RKeLfs3RvJP8XWcV5 L+EPGUssgAJ20ACEPPgjRx0= X-Google-Smtp-Source: AK7set+AvAms7iMGzp4T9Dg6vkGK+GTQJ9v+oSkUBbfrPZ2CpYCZR5nMGdxncdffoDW+8jZMdmWlcA== X-Received: by 2002:a05:6a20:a01c:b0:cb:8a4f:bfb5 with SMTP id p28-20020a056a20a01c00b000cb8a4fbfb5mr13364615pzj.47.1677205240774; Thu, 23 Feb 2023 18:20:40 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id w17-20020a63af11000000b00503000f0492sm928501pge.14.2023.02.23.18.20.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Feb 2023 18:20:40 -0800 (PST) Content-Language: en-US In-Reply-To: <5a38c18d-263c-223b-7335-8395a10eb494@gmail.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::1031; envelope-from=jporterbugs@gmail.com; helo=mail-pj1-x1031.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303731 Archived-At: This is a multi-part message in MIME format. --------------lDf1q6AtWIlmFOg4dms0bukL Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/23/2023 4:50 PM, Jim Porter wrote: > Since the last message I posted, I'm now also seeing this test fail, > though I get a segfault instead. I bisected this to commit > a555abc56d5270cebe94f904189526d7ac433a94 ("Fix order of faces in > 'face-list'"). > > I'm pretty surprised by this, since that patch is *very* simple, but I > can reliably segfault with it, and never segfault without it. I'll keep > digging to see what's going on here. The segfault is in FACE_FROM_ID_OR_NULL, called from Finternal_merge_in_global_face. It happens because the face_cache is null during these tests (since Emacs is noninteractive). The attached patch fixes the issue for me, though I'm not totally sure it's the *right* fix. Any thoughts? (I'm also not 100% sure this is the same issue you're seeing...) --------------lDf1q6AtWIlmFOg4dms0bukL Content-Type: text/plain; charset=UTF-8; name="0001-Fix-segmentation-fault-when-merging-faces-in-a-nonin.patch" Content-Disposition: attachment; filename*0="0001-Fix-segmentation-fault-when-merging-faces-in-a-nonin.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBiY2MxYzQ0ZGNmYWVhYjM5MWNkODVlYzEwNGZmYTI3OWYyODQwOWU0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFRodSwgMjMgRmViIDIwMjMgMTg6MTY6MjggLTA4MDAKU3ViamVjdDogW1BB VENIXSBGaXggc2VnbWVudGF0aW9uIGZhdWx0IHdoZW4gbWVyZ2luZyBmYWNlcyBpbiBhIG5v bmludGVyYWN0aXZlCiBFbWFjcwoKKiBzcmMveGZhY2VzLmMgKGludGVybmFsLW1lcmdlLWlu LWdsb2JhbC1mYWNlKTogU2lnbmFsIGFuIGVycm9yIHdoZW4KJ25vbmludGVyYWN0aXZlJyBp cyB0cnVlLgotLS0KIHNyYy94ZmFjZXMuYyB8IDcgKysrKysrKwogMSBmaWxlIGNoYW5nZWQs IDcgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL3NyYy94ZmFjZXMuYyBiL3NyYy94ZmFj ZXMuYwppbmRleCA2MmQ3ODIzZjMwOC4uMDMxMGQzMjhiOGYgMTAwNjQ0Ci0tLSBhL3NyYy94 ZmFjZXMuYworKysgYi9zcmMveGZhY2VzLmMKQEAgLTQxNjIsNiArNDE2MiwxMyBAQCBERUZV TiAoImludGVybmFsLW1lcmdlLWluLWdsb2JhbC1mYWNlIiwgRmludGVybmFsX21lcmdlX2lu X2dsb2JhbF9mYWNlLAogICBMaXNwX09iamVjdCBnbG9iYWxfbGZhY2UsIGxvY2FsX2xmYWNl LCAqZ3ZlYywgKmx2ZWM7CiAgIHN0cnVjdCBmcmFtZSAqZiA9IFhGUkFNRSAoZnJhbWUpOwog CisgIC8qIElmIHRoaXMgcHJvY2VzcyBpcyBub25pbnRlcmFjdGl2ZSwgd2UgbGlrZWx5IGRv bid0IGhhdmUgYSBmYWNlCisgICAgIGNhY2hlLCBzbyBhdHRlbXB0cyB0byB1c2UgaXQgYmVs b3cgd291bGQgc2VnZmF1bHQuICAqLworICBpZiAobm9uaW50ZXJhY3RpdmUpCisgICAgewor ICAgICAgZXJyb3IgKCJBdHRlbXB0IHRvIG1lcmdlIGZhY2VzIGluIG5vbmludGVyYWN0aXZl IEVtYWNzIik7CisgICAgfQorCiAgIENIRUNLX0xJVkVfRlJBTUUgKGZyYW1lKTsKICAgZ2xv YmFsX2xmYWNlID0gbGZhY2VfZnJvbV9mYWNlX25hbWUgKE5VTEwsIGZhY2UsIHRydWUpOwog ICBsb2NhbF9sZmFjZSA9IGxmYWNlX2Zyb21fZmFjZV9uYW1lIChmLCBmYWNlLCBmYWxzZSk7 Ci0tIAoyLjI1LjEKCg== --------------lDf1q6AtWIlmFOg4dms0bukL--