From: Glenn Morris <rgm@gnu.org>
To: 29611-done@debbugs.gnu.org
Subject: bug#29611: 25.3; help navigation error
Date: Thu, 07 Dec 2017 20:32:07 -0500 [thread overview]
Message-ID: <byfu8m2eeg.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <87r2s6gp31.fsf@gmail.com> (Alex Branham's message of "Thu, 07 Dec 2017 16:17:38 -0600")
Version: 26.0.91
Thanks; looks like an old bug.
commit c0a670a (HEAD, origin/emacs-26, emacs-26)
Date: Thu Dec 7 20:30:39 2017 -0500
* lisp/help-mode.el (help-function-def):
Allow help-make-xrefs to call with one argument. (Bug#29611)
diff --git a/lisp/help-mode.el b/lisp/help-mode.el
index a98bce0..8bafa46 100644
--- a/lisp/help-mode.el
+++ b/lisp/help-mode.el
@@ -192,20 +192,24 @@ 'help-customize-face
(define-button-type 'help-function-def
:supertype 'help-xref
- 'help-function (lambda (fun file &optional type)
- (require 'find-func)
- (when (eq file 'C-source)
- (setq file
- (help-C-file-name (indirect-function fun) 'fun)))
- ;; Don't use find-function-noselect because it follows
- ;; aliases (which fails for built-in functions).
- (let ((location
- (find-function-search-for-symbol fun type file)))
- (pop-to-buffer (car location))
- (run-hooks 'find-function-after-hook)
- (if (cdr location)
- (goto-char (cdr location))
- (message "Unable to find location in file"))))
+ 'help-function (lambda (fun &optional file type)
+ (or file
+ (setq file (find-lisp-object-file-name fun type)))
+ (if (not file)
+ (message "Unable to find defining file")
+ (require 'find-func)
+ (when (eq file 'C-source)
+ (setq file
+ (help-C-file-name (indirect-function fun) 'fun)))
+ ;; Don't use find-function-noselect because it follows
+ ;; aliases (which fails for built-in functions).
+ (let ((location
+ (find-function-search-for-symbol fun type file)))
+ (pop-to-buffer (car location))
+ (run-hooks 'find-function-after-hook)
+ (if (cdr location)
+ (goto-char (cdr location))
+ (message "Unable to find location in file")))))
'help-echo (purecopy "mouse-2, RET: find function's definition"))
(define-button-type 'help-function-cmacro ; FIXME: Obsolete since 24.4.
@@ -495,12 +499,6 @@ help-make-xrefs
(help-xref-button 8 'help-face sym)))
((match-string 6)) ; nothing for `symbol'
((match-string 7)
- ;; this used:
- ;; #'(lambda (arg)
- ;; (let ((location
- ;; (find-function-noselect arg)))
- ;; (pop-to-buffer (car location))
- ;; (goto-char (cdr location))))
(help-xref-button 8 'help-function-def sym))
((cl-some (lambda (x) (funcall (nth 1 x) sym))
describe-symbol-backends)
prev parent reply other threads:[~2017-12-08 1:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 22:17 bug#29611: 25.3; help navigation error Alex Branham
2017-12-08 1:32 ` Glenn Morris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=byfu8m2eeg.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=29611-done@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.