face names in blank-mode.el

face names in blank-mode.el

[Dan Nicolaescu]

Isn't using the -face suffix for faces deprecated now?
The new package blank-mode.el that was very recently added does it for
all of its faces:

$ grep defface blank-mode.el
;; indicating defface byte-compilation warnings.
(defface blank-space-face
(defface blank-hspace-face              ; 'nobreak-space
(defface blank-tab-face
(defface blank-newline-face
(defface blank-trailing-face            ; 'trailing-whitespace
(defface blank-line-face
(defface blank-space-before-tab-face

Re: face names in blank-mode.el

[Glenn Morris]

Dan Nicolaescu wrote:

> Isn't using the -face suffix for faces deprecated now?

Not deprecated, just plain wrong.

See display.texi "Defining Faces":

"it should not end in @samp{-face} (that would be redundant)."

Re: face names in blank-mode.el

[Miles Bader]

Vinicius Jose Latorre <viniciusjl@ig.com.br> writes:
>> $ grep defface blank-mode.el
>
> Other packages also have "-face" suffix: font-lock, planner.

font-lock-* faces keep the suffix for histerical reasons; any others are
bugs.

-Miles

-- 
Bacchus, n. A convenient deity invented by the ancients as an excuse for
getting drunk.

Re: face names in blank-mode.el

[Miles Bader]

Vinicius Jose Latorre <viniciusjl@ig.com.br> writes:
>> font-lock-* faces keep the suffix for histerical reasons; any others are
>> bugs.
>
> Maybe you mean "historical", isn't it?

Yeah, well, both really :-)

-Miles

-- 
Helpmate, n. A wife, or bitter half.

Re: face names in blank-mode.el

[Vinicius Jose Latorre]

> Isn't using the -face suffix for faces deprecated now?
> The new package blank-mode.el that was very recently added does it for
> all of its faces:
>
> $ grep defface blank-mode.el
> ;; indicating defface byte-compilation warnings.
> (defface blank-space-face
> (defface blank-hspace-face              ; 'nobreak-space
> (defface blank-tab-face
> (defface blank-newline-face
> (defface blank-trailing-face            ; 'trailing-whitespace
> (defface blank-line-face
> (defface blank-space-before-tab-face
>   

Other packages also have "-face" suffix: font-lock, planner.

Re: face names in blank-mode.el

[Vinicius Jose Latorre]

>>> $ grep defface blank-mode.el
>>>       
>> Other packages also have "-face" suffix: font-lock, planner.
>>     
>
> font-lock-* faces keep the suffix for histerical reasons; any others are
> bugs.
>   

Maybe you mean "historical", isn't it?

Ok, I'll eliminate -face suffix tomorrow.

Re: face names in blank-mode.el

[Vinicius Jose Latorre]

>>>> $ grep defface blank-mode.el
>>>>       
>>> Other packages also have "-face" suffix: font-lock, planner.  
>>
>> font-lock-* faces keep the suffix for histerical reasons; any others are
>> bugs.   
>
> Maybe you mean "historical", isn't it?
>
> Ok, I'll eliminate -face suffix tomorrow.

"-face" suffix just eliminated in CVS trunk and emacs 22 branch.