From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Miles Bader Newsgroups: gmane.emacs.devel Subject: uniquify & advice Date: 06 Jun 2003 13:16:27 +0900 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: Reply-To: Miles Bader NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1054872988 1947 80.91.224.249 (6 Jun 2003 04:16:28 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Fri, 6 Jun 2003 04:16:28 +0000 (UTC) Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Fri Jun 06 06:16:27 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19O8eR-0000VH-00 for ; Fri, 06 Jun 2003 06:16:27 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 19O8wo-00016Q-00 for ; Fri, 06 Jun 2003 06:35:26 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.20) id 19O8gP-0004xa-3d for emacs-devel@quimby.gnus.org; Fri, 06 Jun 2003 00:18:29 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.20) id 19O8fy-0004Yu-1S for emacs-devel@gnu.org; Fri, 06 Jun 2003 00:18:02 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.20) id 19O8ez-0003De-HD for emacs-devel@gnu.org; Fri, 06 Jun 2003 00:17:01 -0400 Original-Received: from tyo201.gate.nec.co.jp ([202.32.8.214]) by monty-python.gnu.org with esmtp (Exim 4.20) id 19O8eX-0001dV-Ng; Fri, 06 Jun 2003 00:16:34 -0400 Original-Received: from mailgate4.nec.co.jp ([10.7.69.193])h564GTw02386; Fri, 6 Jun 2003 13:16:29 +0900 (JST) Original-Received: from mailsv4.nec.co.jp (mailgate51.nec.co.jp [10.7.69.196]) by mailgate4.nec.co.jp (8.11.6/3.7W-MAILGATE-NEC) with ESMTP id h564GSi07168; Fri, 6 Jun 2003 13:16:28 +0900 (JST) Original-Received: from edtmg03.lsi.nec.co.jp ([10.26.16.203]) by mailsv4.nec.co.jp (8.11.6/3.7W-MAILSV4-NEC) with ESMTP id h564GS324846; Fri, 6 Jun 2003 13:16:28 +0900 (JST) Original-Received: from mcsss2.ucom.lsi.nec.co.jp (localhost [127.0.0.1]) id NAA09304; Fri, 6 Jun 2003 13:16:28 +0900 (JST) Original-Received: from mcspd15.ucom.lsi.nec.co.jp (mcspd15 [10.30.114.174]) with ESMTP id h564GRNH011703; Fri, 6 Jun 2003 13:16:27 +0900 (JST) Original-Received: by mcspd15.ucom.lsi.nec.co.jp (Postfix, from userid 31295) id 45B223732; Fri, 6 Jun 2003 13:16:27 +0900 (JST) Original-To: emacs-devel@gnu.org System-Type: i686-pc-linux-gnu Blat: Foop Original-Lines: 16 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:14811 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:14811 uniquify.el still uses `defadvice' for some of its functionality; shouldn't we just add appropriate code (or hooks) to the underlying functions instead? Here's what it uses: (defadvice rename-buffer (after rename-buffer-uniquify activate) "Uniquify buffer names with parts of directory name." (defadvice create-file-buffer (after create-file-buffer-uniquify activate) "Uniquify buffer names with parts of directory name." -Miles -- "I distrust a research person who is always obviously busy on a task." --Robert Frosch, VP, GM Research