all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Miles Bader <miles@lsi.nec.co.jp>
Cc: Andreas Schwab <schwab@suse.de>, emacs-devel@gnu.org
Subject: Re: [PATCH] Delayed loading of image libraries
Date: Thu, 01 Jul 2004 18:48:46 +0900	[thread overview]
Message-ID: <buovfh8t5vl.fsf@mctpc71.ucom.lsi.nec.co.jp> (raw)
In-Reply-To: <20040701110632.415E.JMBARRANQUERO@wke.es> (Juanma Barranquero's message of "Thu, 01 Jul 2004 11:30:49 +0200")

Juanma Barranquero <jmbarranquero@wke.es> writes:
>> The result of `create-image' can be saved in a lisp file, and later loaded,
>> in which case the image will be displayed without `init-image-library' being
>> called from `image-type-available-p'y
>
> It can be loaded, sure, but can it be *displayed* without
> `image-type-available-p' being called?  I'd say that's a bug.

With my patch they can.

Images are (currently) perfectly valid lisp values; if we don't want
them to be readable and writable to files, we should make them an opaque
type.

But that seems like a stupid thing to do.  Just make the C code deal
with the situation.  If my patch was wrong (though I admit, I still have
no idea why -- your discussion so far doesn't make much sense to me),
fix it, but don't remove the functionality it adds.

[Note that reading and writing images to files (and displaying them in a
new emacs instance, by just reading the file) worked fine before the
changes that added Finit_image_library etc., so the bug I fixed is a
regression.]

-Miles
-- 
My spirit felt washed.  With blood.  [Eli Shin, on "The Passion of the Christ"]

  reply	other threads:[~2004-07-01  9:48 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-10 12:38 [PATCH] Delayed loading of image libraries Juanma Barranquero
2004-06-30 10:15 ` Andreas Schwab
2004-06-30 11:13   ` Juanma Barranquero
2004-06-30 11:24     ` Andreas Schwab
2004-06-30 11:34       ` Juanma Barranquero
2004-06-30 11:41         ` Andreas Schwab
2004-06-30 13:00           ` Juanma Barranquero
2004-06-30 15:42         ` Miles Bader
2004-07-01  9:30           ` Juanma Barranquero
2004-07-01  9:48             ` Miles Bader [this message]
2004-07-01 10:13               ` Juanma Barranquero
2004-07-02  1:16                 ` Miles Bader
2004-07-02  7:02                   ` Juanma Barranquero
2004-07-02  7:10                     ` David Kastrup
2004-07-02  7:41                       ` Juanma Barranquero
2004-07-02  7:56                         ` Miles Bader
2004-07-02  8:10                           ` Juanma Barranquero
2004-07-02  8:20                             ` Miles Bader
2004-07-02  8:45                               ` Juanma Barranquero
2004-07-02  8:59                                 ` Miles Bader
2004-07-02  9:02                                   ` Miles Bader
2004-07-02  8:11                         ` David Kastrup
2004-07-02  8:34                           ` Juanma Barranquero
2004-07-03 18:21                     ` Richard Stallman
2004-06-30 14:19       ` Stefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=buovfh8t5vl.fsf@mctpc71.ucom.lsi.nec.co.jp \
    --to=miles@lsi.nec.co.jp \
    --cc=emacs-devel@gnu.org \
    --cc=miles@gnu.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.