From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Miles Bader Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Delayed loading of image libraries Date: Fri, 02 Jul 2004 16:56:51 +0900 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <20040702085419.CF31.JMBARRANQUERO@wke.es> <20040702093521.CF34.JMBARRANQUERO@wke.es> Reply-To: Miles Bader NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1088755085 24966 80.91.224.253 (2 Jul 2004 07:58:05 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 2 Jul 2004 07:58:05 +0000 (UTC) Cc: Andreas Schwab , David Kastrup , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Fri Jul 02 09:57:56 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BgIvk-0006ao-00 for ; Fri, 02 Jul 2004 09:57:56 +0200 Original-Received: from lists.gnu.org ([199.232.76.165]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BgIvk-0001OA-00 for ; Fri, 02 Jul 2004 09:57:56 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BgIxY-0005t9-Au for emacs-devel@quimby.gnus.org; Fri, 02 Jul 2004 03:59:48 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BgIxT-0005t4-F1 for emacs-devel@gnu.org; Fri, 02 Jul 2004 03:59:43 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BgIxQ-0005sG-OR for emacs-devel@gnu.org; Fri, 02 Jul 2004 03:59:42 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BgIxQ-0005s2-FG for emacs-devel@gnu.org; Fri, 02 Jul 2004 03:59:40 -0400 Original-Received: from [202.32.8.202] (helo=TYO202.gate.nec.co.jp) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BgIvL-0000E3-7K; Fri, 02 Jul 2004 03:57:31 -0400 Original-Received: from mailgate4.nec.co.jp (mailgate54.nec.co.jp [10.7.69.195]) by TYO202.gate.nec.co.jp (8.11.7/3.7W01080315) with ESMTP id i627uuY22836; Fri, 2 Jul 2004 16:56:56 +0900 (JST) Original-Received: (from root@localhost) by mailgate4.nec.co.jp (8.11.7/3.7W-MAILGATE-NEC) id i627uuC24655; Fri, 2 Jul 2004 16:56:56 +0900 (JST) Original-Received: from edsgm02.lsi.nec.co.jp ([10.50.208.12]) by mailsv3.nec.co.jp (8.11.7/3.7W-MAILSV4-NEC) with ESMTP id i627utO02063; Fri, 2 Jul 2004 16:56:55 +0900 (JST) Original-Received: from mcsss2.ucom.lsi.nec.co.jp (localhost [127.0.0.1]) by edsgm02.lsi.nec.co.jp (8.12.10/8.12.10) with ESMTP id i627urHx007614; Fri, 2 Jul 2004 16:56:54 +0900 (JST) Original-Received: from mctpc71 (mctpc71.ucom.lsi.nec.co.jp [10.30.118.121]) by mcsss2.ucom.lsi.nec.co.jp (8.12.10/8.12.8/EDcg v2.01-mc/1046780839) with ESMTP id i627uqIm008454; Fri, 2 Jul 2004 16:56:52 +0900 (JST) Original-Received: by mctpc71 (Postfix, from userid 31295) id 0219B48D; Fri, 2 Jul 2004 16:56:51 +0900 (JST) Original-To: Juanma Barranquero System-Type: i686-pc-linux-gnu Blat: Foop In-Reply-To: <20040702093521.CF34.JMBARRANQUERO@wke.es> (Juanma Barranquero's message of "Fri, 02 Jul 2004 09:41:53 +0200") Original-Lines: 22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:25378 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:25378 Juanma Barranquero writes: > Sure. But currently, an Emacs supporting PNG *will* display a PNG if > the library is made available (either statically or dynamically). Miles > thinks (or so I understand) that the responsability of making the > library available rests on lookup_image_type. I have no particular opinion about which exact function does it, but it _should_ be done `transparently' -- that is any place where a lisp value is used to compute deeper information (for display or otherwise). Two important functions for that are `valid_image_p' (called by all sorts of image-manipulation functions), and `lookup_image' (called by the display engine). Both of those call `lookup_image_type', and thus my placing a call to image-type-validation there. If I omitted an argument, obviously my change was flawed, but the location seems reasonable. -Miles -- We are all lying in the gutter, but some of us are looking at the stars. -Oscar Wilde