`font-face-attributes' sometimes returns bogus :height value

`font-face-attributes' sometimes returns bogus :height value

[Miles Bader]

If `font-face-attributes' is called without a specified height, it
returns an attribute list containing `:height nil', which is invalid.

E.g.

   (font-face-attributes "Dejavu Serif")
   => (:family "Dejavu Serif" :height nil :weight normal :slant normal :width normal)

Since it is quite useful to work with no specified, I think this case
should be supported properly.

To make this work means either omitting the :height attribute entirely
from the returned attribute-list, or alternatively, keeping it, but
using `:height unspecified' for the height.

I dunno what's the preferred way, but I would tentatively favor simply
omitting :height altogether, and making it clear in the function
documentation that the exact order/contents of the returned attribute
list is not guaranteed.

-Miles

-- 
Un-American, adj. Wicked, intolerable, heathenish.

Re: `font-face-attributes' sometimes returns bogus :height value

[Kenichi Handa]

In article <buor6awpxqn.fsf@dhapc248.dev.necel.com>, Miles Bader <miles.bader@necel.com> writes:

> If `font-face-attributes' is called without a specified height, it
> returns an attribute list containing `:height nil', which is invalid.

> E.g.

>    (font-face-attributes "Dejavu Serif")
>>> (:family "Dejavu Serif" :height nil :weight normal :slant normal :width normal)

> Since it is quite useful to work with no specified, I think this case
> should be supported properly.

> To make this work means either omitting the :height attribute entirely
> from the returned attribute-list, or alternatively, keeping it, but
> using `:height unspecified' for the height.

I think :weight thru :width should also be omitted or
`unspecified' in the above case.

---
Kenichi Handa
handa@ni.aist.go.jp

Re: `font-face-attributes' sometimes returns bogus :height value

[Miles Bader]

Kenichi Handa <handa@m17n.org> writes:
>> If `font-face-attributes' is called without a specified height, it
>> returns an attribute list containing `:height nil', which is invalid.
>
> I think :weight thru :width should also be omitted or
> `unspecified' in the above case.

Sounds good to me...

[are you working on this, or do you want me to?]

Thanks,

-Miles

-- 
"Though they may have different meanings, the cries of 'Yeeeee-haw!' and
 'Allahu akbar!' are, in spirit, not actually all that different."

Re: `font-face-attributes' sometimes returns bogus :height value

[Chong Yidong]

Miles Bader <miles@gnu.org> writes:

> Kenichi Handa <handa@m17n.org> writes:
>>> If `font-face-attributes' is called without a specified height, it
>>> returns an attribute list containing `:height nil', which is invalid.
>>
>> I think :weight thru :width should also be omitted or
>> `unspecified' in the above case.
>
> Sounds good to me...
>
> [are you working on this, or do you want me to?]

I'll work on it.

Re: `font-face-attributes' sometimes returns bogus :height value

[Chong Yidong]

Kenichi Handa <handa@m17n.org> writes:

>> If `font-face-attributes' is called without a specified height, it
>> returns an attribute list containing `:height nil', which is invalid.
>
>> E.g.
>
>>    (font-face-attributes "Dejavu Serif")
>>>> (:family "Dejavu Serif" :height nil :weight normal :slant normal :width normal)
>
>> Since it is quite useful to work with no specified, I think this case
>> should be supported properly.
>
>> To make this work means either omitting the :height attribute entirely
>> from the returned attribute-list, or alternatively, keeping it, but
>> using `:height unspecified' for the height.
>
> I think :weight thru :width should also be omitted or
> `unspecified' in the above case.

Why should it affect the :weight and :slant parameters?  The user can
specify "Dejavu Serif Bold Itallic" or "Dejavu Serif:bold:italic", etc.

Re: `font-face-attributes' sometimes returns bogus :height value

[Miles Bader]

Chong Yidong <cyd@stupidchicken.com> writes:
>>> To make this work means either omitting the :height attribute entirely
>>> from the returned attribute-list, or alternatively, keeping it, but
>>> using `:height unspecified' for the height.
>>
>> I think :weight thru :width should also be omitted or
>> `unspecified' in the above case.
>
> Why should it affect the :weight and :slant parameters?  The user can
> specify "Dejavu Serif Bold Itallic" or "Dejavu Serif:bold:italic", etc.

I think the main point is that while `font-face-attributes' _can_ return
:weight, :width, etc., parameters, it should only do so if the user
explicitly specified them.  Right now it seems to always do so.

So, ideally:

    (font-face-attributes "Dejavu Serif")
    => (:family "Dejavu Serif")

    (font-face-attributes "Dejavu Serif-10")
    => (:family "Dejavu Serif" :height 100)

    (font-face-attributes "Dejavu Serif Italic")
    => (:family "Dejavu Serif" :slant italic)

etc.

-- 
Conservative, n. A statesman enamored of existing evils, as opposed to a
Liberal, who wants to replace them with new ones.

Re: `font-face-attributes' sometimes returns bogus :height value

[Kenichi Handa]

In article <87wskoxgi2.fsf@stupidchicken.com>, Chong Yidong <cyd@stupidchicken.com> writes:

> Kenichi Handa <handa@m17n.org> writes:
>>> If `font-face-attributes' is called without a specified height, it
>>> returns an attribute list containing `:height nil', which is invalid.
> >
E.g.
> >
>>> (font-face-attributes "Dejavu Serif")
>>>>> (:family "Dejavu Serif" :height nil :weight normal :slant normal :width normal)
> >
>>> Since it is quite useful to work with no specified, I think this case
>>> should be supported properly.
> >
>>> To make this work means either omitting the :height attribute entirely
>>> from the returned attribute-list, or alternatively, keeping it, but
>>> using `:height unspecified' for the height.
> >
> > I think :weight thru :width should also be omitted or
> > `unspecified' in the above case.

> Why should it affect the :weight and :slant parameters?  The user can
> specify "Dejavu Serif Bold Itallic" or "Dejavu Serif:bold:italic", etc.

Because just "Dejavu Serif" doesn't specify any
style-related properties.

---
Kenichi Handa
handa@ni.aist.go.jp

Re: `font-face-attributes' sometimes returns bogus :height value

[Chong Yidong]

>>> If `font-face-attributes' is called without a specified height, it
>>> returns an attribute list containing `:height nil', which is invalid.
>>
>>> Since it is quite useful to work with no specified, I think this case
>>> should be supported properly.
>>
>>> To make this work means either omitting the :height attribute entirely
>>> from the returned attribute-list, or alternatively, keeping it, but
>>> using `:height unspecified' for the height.
>>
>> I think :weight thru :width should also be omitted or
>> `unspecified' in the above case.

Done.