all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Miles Bader <miles@gnu.org>
To: emacs-devel@gnu.org
Subject: vc-git-log-incoming
Date: Wed, 02 Jun 2010 17:49:42 +0900	[thread overview]
Message-ID: <buor5kpx1i1.fsf@dhlpc061.dev.necel.com> (raw)

vc-git-log-incoming seems to have a bunch of problems:

 (1) By default, it uses "git log HEAD..XXX", where XXX is
     (vc-git-compute-remote), but this is only correct in some cases,
     because the current branch and the branch being pulled from don't
     necessarily have the same name (it failed on my emacs checkout, for
     instance).

     More correct would be to just use "HEAD..@{upstream}", which should
     use the actual upstream branch; however I think the "@{upstream}"
     feature was only added in git 1.7.0.

 (2) If the user doesn't use the default, it just does "git log YYY",
     where YYY is what the user entered, but this is probably not what's
     wanted; really it should use "HEAD..YYY".

 (3) Most seriously, just using git-log like this doesn't actually give
     a list of what will be pulled, because "git pull" first updates the
     local copy of the remote's branches, whereas "git log" does not.

     I'm not totally sure how to do this correctly -- you can get the
     range of revisions that would be added during pulling (by the
     underlying call to "git fetch") by using "git fetch --dry-run", but
     that's not going to give you a log output....

Thanks,

-miles

-- 
Carefully crafted initial estimates reward you not only with
reduced computational effort, but also with understanding and
increased self-esteem.         -- Numerical methods in C,
  Chapter 9. "Root Finding and Nonlinear Sets of Equations"



             reply	other threads:[~2010-06-02  8:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-02  8:49 Miles Bader [this message]
2010-06-02  9:23 ` vc-git-log-incoming Dan Nicolaescu
2010-06-02 10:38   ` vc-git-log-incoming Miles Bader
2010-06-03 23:41     ` vc-git-log-incoming Dan Nicolaescu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=buor5kpx1i1.fsf@dhlpc061.dev.necel.com \
    --to=miles@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.