From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Miles Bader Newsgroups: gmane.emacs.devel Subject: Re: & requires l-value Date: 21 May 2002 18:20:28 +0900 Sender: emacs-devel-admin@gnu.org Message-ID: References: <20020521090847.8B44.LEKTU@terra.es> Reply-To: Miles Bader NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1021973035 27518 127.0.0.1 (21 May 2002 09:23:55 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Tue, 21 May 2002 09:23:55 +0000 (UTC) Cc: Juanma Barranquero , emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.33 #1 (Debian)) id 17A5s3-00079j-00 for ; Tue, 21 May 2002 11:23:55 +0200 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 17A66O-0000RN-00 for ; Tue, 21 May 2002 11:38:45 +0200 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 17A5sN-00079g-00; Tue, 21 May 2002 05:24:15 -0400 Original-Received: from tyo202.gate.nec.co.jp ([210.143.35.52]) by fencepost.gnu.org with smtp (Exim 3.34 #1 (Debian)) id 17A5pG-0006zZ-00; Tue, 21 May 2002 05:21:04 -0400 Original-Received: from mailgate4.nec.co.jp ([10.7.69.193]) by TYO202.gate.nec.co.jp (8.11.6/3.7W01080315) with ESMTP id g4L9KWR06435; Tue, 21 May 2002 18:20:32 +0900 (JST) Original-Received: from mailsv4.nec.co.jp (mailgate51.nec.co.jp [10.7.69.190]) by mailgate4.nec.co.jp (8.11.6/3.7W-MAILGATE-NEC) with ESMTP id g4L9KVZ08090; Tue, 21 May 2002 18:20:31 +0900 (JST) Original-Received: from mcsss2.ucom.lsi.nec.co.jp ([10.30.114.133]) by mailsv4.nec.co.jp (8.11.6/3.7W-MAILSV4-NEC) with ESMTP id g4L9KU826174; Tue, 21 May 2002 18:20:30 +0900 (JST) Original-Received: from mcspd15.ucom.lsi.nec.co.jp (mcspd15 [10.30.114.174]) by mcsss2.ucom.lsi.nec.co.jp (8.10.2+Sun/3.7Wlsi_mx_6.0) with ESMTP id g4L9KTK02968; Tue, 21 May 2002 18:20:29 +0900 (JST) Original-Received: by mcspd15.ucom.lsi.nec.co.jp (Postfix, from userid 31295) id 9485B3722; Tue, 21 May 2002 18:20:28 +0900 (JST) Original-To: Ken Raeburn System-Type: i686-pc-linux-gnu Blat: Foop In-Reply-To: Original-Lines: 21 Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.9 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:4232 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:4232 Ken Raeburn writes: > > That code seems kind of dodgy to me though; it seems cleaner to just > > make the `tail' field in enumfont_t a normal Lisp_Object that points to > > either Qnil or a cons cell, and do the list splicing doing XSETCDR (it > > has a pointer to the head of the list anyway, so the nil case isn't a > > problem). > > This is the better approach, even though it requires a little work. It looks like _very_ little work, actually -- there's only two places that actually seem to reference the `tail' field. Morever, that seems to be the only place left in emacs that takes the address of XCAR/XCDR, so I'd say it's well worth doing. I'd do it, since it's so easy, but perhaps it's better left to the w32 maintainer, who can test it. -Miles -- P.S. All information contained in the above letter is false, for reasons of military security.