all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Miles Bader <miles@lsi.nec.co.jp>
Cc: Juanma Barranquero <lektu@terra.es>, emacs-devel@gnu.org
Subject: Re: & requires l-value
Date: 21 May 2002 18:20:28 +0900	[thread overview]
Message-ID: <buooff9vov7.fsf@mcspd15.ucom.lsi.nec.co.jp> (raw)
In-Reply-To: <tx1661han4h.fsf@raeburn.org>

Ken Raeburn <raeburn@raeburn.org> writes:
> > That code seems kind of dodgy to me though; it seems cleaner to just
> > make the `tail' field in enumfont_t a normal Lisp_Object that points to
> > either Qnil or a cons cell, and do the list splicing doing XSETCDR (it
> > has a pointer to the head of the list anyway, so the nil case isn't a
> > problem).
> 
> This is the better approach, even though it requires a little work.

It looks like _very_ little work, actually -- there's only two places
that actually seem to reference the `tail' field.

Morever, that seems to be the only place left in emacs that takes the
address of XCAR/XCDR, so I'd say it's well worth doing.  I'd do it,
since it's so easy, but perhaps it's better left to the w32 maintainer,
who can test it.

-Miles
-- 
P.S.  All information contained in the above letter is false,
      for reasons of military security.

  reply	other threads:[~2002-05-21  9:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-05-21  7:11 & requires l-value Juanma Barranquero
2002-05-21  7:39 ` Miles Bader
2002-05-21  9:03 ` Ken Raeburn
2002-05-21  9:20   ` Miles Bader [this message]
2002-05-21 20:39   ` Jason Rumney
2002-05-21 21:36     ` Ken Raeburn
2002-05-22  7:05       ` Juanma Barranquero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=buooff9vov7.fsf@mcspd15.ucom.lsi.nec.co.jp \
    --to=miles@lsi.nec.co.jp \
    --cc=emacs-devel@gnu.org \
    --cc=lektu@terra.es \
    --cc=miles@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.