From: Miles Bader <miles.bader@necel.com>
To: rms@gnu.org
Cc: reinersteib+gmane@imap.cc, andreas.roehler@online.de,
emacs-devel@gnu.org, juri@jurta.org, monnier@iro.umontreal.ca,
stephen@xemacs.org, drew.adams@oracle.com
Subject: Re: region-active-p
Date: Thu, 01 Nov 2007 11:33:53 +0900 [thread overview]
Message-ID: <buomytyu226.fsf@dhapc248.dev.necel.com> (raw)
In-Reply-To: <E1InNRt-00051U-VT@fencepost.gnu.org> (Richard Stallman's message of "Wed\, 31 Oct 2007 19\:58\:13 -0400")
Richard Stallman <rms@gnu.org> writes:
> > That name seems ok to me. But I think that `region-overrides-p'
> > hits it more accurately.
>
> Overrides what?
>
> Overrides the command's usual behavior.
Perhaps that's how it's usually used, but to name the predicate based on
that seems sort of weird.
If I see code like:
(if (region-active-p)
...do-this...
...do-that...)
It seems fairly clear to me what's going on (I'm assuming that people
can intuitively grasp the idea of an active region -- given the
commonness of this concept, and the suggestivenss of the term, I think
they can).
But this:
(if (region-overrides-p)
...do-this...
...do-that...)
(1) Obscures the fact that the _reason_ for overriding the is that the
region is active. It sounds "arbitrary".
In fact, upon first seeing it, it sounds like maybe there might be a
"region-override" flag somewhere which controls the behavior, or
that the rules were too complex to find a good intuitive name, and
one must examine `region-override-p' to see what the actual rules
are (I don't think this is true -- I think the _concept_ is pretty
concise). This makes the code harder to understand.
(2) It requires the concept of "usual" behavior to be understood,
whereas a name phrased in terms. Perhaps in many cases that's OK,
but it seems like an unnecessary bit of extra information one is
required to know.
One can imagine a command where the "usual" case the active-region
case, but which also has a useful non-active behavior. For a
command like this, the name "overrides" is awkward.
Anyway, what I'm trying to say is that a name like `region-override-p'
makes code harder to understand.
-Miles
--
"Whatever you do will be insignificant, but it is very important that
you do it." Mahatma Gandhi
next prev parent reply other threads:[~2007-11-01 2:33 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 9:49 region-active-p Andreas Röhler
2007-10-19 20:57 ` region-active-p Juri Linkov
2007-10-21 7:25 ` region-active-p Richard Stallman
2007-10-21 13:56 ` region-active-p Stefan Monnier
2007-10-21 14:48 ` region-active-p Miles Bader
2007-10-21 19:22 ` region-active-p Andreas Röhler
2007-10-23 7:12 ` region-active-p Richard Stallman
2007-10-23 8:53 ` region-active-p Andreas Röhler
2007-10-23 17:53 ` region-active-p Richard Stallman
2007-10-24 7:33 ` region-active-p Andreas Röhler
2007-10-25 2:10 ` region-active-p Richard Stallman
2007-10-24 19:34 ` region-active-p Stephen J. Turnbull
2007-10-25 9:01 ` region-active-p Richard Stallman
2007-10-26 5:38 ` region-active-p Stephen J. Turnbull
2007-10-26 8:17 ` region-active-p Andreas Röhler
2007-10-26 9:21 ` region-active-p Stephen J. Turnbull
2007-10-26 11:03 ` region-active-p Andreas Röhler
2007-10-26 21:53 ` region-active-p Stephen J. Turnbull
2007-10-27 2:28 ` region-active-p Richard Stallman
2007-10-27 5:20 ` region-active-p Stephen J. Turnbull
2007-10-27 6:17 ` region-active-p Miles Bader
2007-10-27 7:57 ` region-active-p Andreas Röhler
2007-10-28 6:55 ` region-active-p Stephen J. Turnbull
2007-10-28 7:32 ` region-active-p Miles Bader
2007-10-28 12:15 ` region-active-p Johan Bockgård
2007-10-28 21:07 ` region-active-p Stefan Monnier
2007-10-28 21:07 ` region-active-p Stefan Monnier
2007-10-27 23:41 ` region-active-p Richard Stallman
2007-10-28 1:21 ` region-active-p Stefan Monnier
2007-10-28 1:27 ` region-active-p Miles Bader
2007-10-28 2:43 ` region-active-p Stefan Monnier
2007-10-29 0:11 ` region-active-p Richard Stallman
2007-10-29 1:40 ` region-active-p Stefan Monnier
2007-12-10 23:08 ` region-active-p Richard Stallman
2007-12-11 8:15 ` region-active-p Andreas Röhler
2007-12-11 9:57 ` region-active-p Juri Linkov
2007-12-11 11:52 ` region-active-p Andreas Röhler
2007-12-11 14:55 ` region-active-p Stefan Monnier
2007-12-11 17:05 ` region-active-p Andreas Röhler
2007-12-11 18:16 ` region-active-p Stefan Monnier
2007-12-11 9:07 ` region-active-p Andreas Röhler
2007-12-11 9:59 ` region-active-p Juri Linkov
2007-12-11 11:50 ` region-active-p Andreas Röhler
2007-10-28 7:29 ` region-active-p Stephen J. Turnbull
2007-10-28 21:06 ` region-active-p Stefan Monnier
2007-10-29 0:11 ` region-active-p Richard Stallman
2007-10-30 0:12 ` region-active-p Stephen J. Turnbull
2007-10-30 8:22 ` region-active-p Richard Stallman
2007-10-30 8:59 ` region-active-p David Kastrup
2007-10-31 7:46 ` region-active-p Richard Stallman
2007-10-30 15:03 ` region-active-p Drew Adams
2007-10-30 19:03 ` region-active-p Stefan Monnier
2007-10-30 19:49 ` region-active-p Drew Adams
2007-10-30 20:15 ` region-active-p Stefan Monnier
2007-10-30 20:28 ` region-active-p Drew Adams
2007-10-30 21:30 ` region-active-p Stefan Monnier
2007-10-30 23:43 ` region-active-p Miles Bader
2007-10-31 6:35 ` region-active-p David Kastrup
2007-10-31 7:59 ` region-active-p Miles Bader
2007-11-03 21:08 ` region-active-p Stephen J. Turnbull
2007-10-31 7:47 ` region-active-p Richard Stallman
2007-10-31 7:47 ` region-active-p Richard Stallman
2007-10-31 8:00 ` region-active-p Miles Bader
2007-10-31 23:58 ` region-active-p Richard Stallman
2007-11-01 2:33 ` Miles Bader [this message]
2007-11-01 2:55 ` region-active-p Stefan Monnier
2007-11-01 10:06 ` region-active-p Kim F. Storm
2007-11-01 15:46 ` region-active-p Drew Adams
2007-11-01 17:56 ` region-active-p David Kastrup
2007-11-01 23:08 ` region-active-p Richard Stallman
2007-11-01 19:04 ` region-active-p Richard Stallman
2007-11-02 0:18 ` region-active-p Miles Bader
2007-11-02 15:02 ` region-active-p Richard Stallman
2007-11-02 21:39 ` region-active-p Stefan Monnier
2007-11-02 22:31 ` region-active-p Miles Bader
2007-11-03 20:48 ` region-active-p Richard Stallman
2007-11-05 6:48 ` region-active-p Miles Bader
2007-10-29 8:24 ` region-active-p Andreas Röhler
2007-10-22 6:09 ` region-active-p Andreas Röhler
2007-10-21 17:18 ` region-active-p Stephen J. Turnbull
2007-10-21 20:54 ` region-active-p Reiner Steib
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=buomytyu226.fsf@dhapc248.dev.necel.com \
--to=miles.bader@necel.com \
--cc=andreas.roehler@online.de \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
--cc=juri@jurta.org \
--cc=miles@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=reinersteib+gmane@imap.cc \
--cc=rms@gnu.org \
--cc=stephen@xemacs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.