Bug in emacsbug.el

Bug in emacsbug.el

[Lennart Borgman]

I think this test in `report-emacs-bug' tests the wrong mail address:

       ;; Insert warnings for novice users.
       (when (string-match "@gnu\\.org^" reporting-address)
	(insert "This bug report will be sent to the Free Software Foundation,\n")
	(let ((pos (point)))
	  (insert "not to your local site managers!")
	  (put-text-property pos (point) 'face 'highlight)))

Should it not test `user-mail-address' instead?

Re: Bug in emacsbug.el

[Michaël Cadilhac]

[-- Attachment #1.1: Type: text/plain, Size: 1171 bytes --]

Lennart Borgman <lennart.borgman.073@student.lu.se> writes:

> I think this test in `report-emacs-bug' tests the wrong mail address:
>
>       ;; Insert warnings for novice users.
>       (when (string-match "@gnu\\.org^" reporting-address)
> 	(insert "This bug report will be sent to the Free Software Foundation,\n")
> 	(let ((pos (point)))
> 	  (insert "not to your local site managers!")
> 	  (put-text-property pos (point) 'face 'highlight)))
>
> Should it not test `user-mail-address' instead?

Don't think so.  This warning is here to warn the user that the email
(s)he writes is GOING TO the FSF, not to the local sysadmin.

Why do you want to test user-mail-address? Maybe something's missing
in the warning set of emacsbug in your opinion?

-- 
/!\ My mail address has changed, please update your files accordingly.
 |      Michaël `Micha' Cadilhac     |  (\(\  This is the cute bunny virus,   |
 |         Epita/LRDE Promo 2007     |  (^.^)  please copy this into your     |
 |  http://michael.cadilhac.name     |  (")")  sig so it can spread.          |
 `--JID: michael.cadilhac@gmail.com--'                                   -  --'

[-- Attachment #1.2: Type: application/pgp-signature, Size: 188 bytes --]

[-- Attachment #2: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: Bug in emacsbug.el

[Lennart Borgman]

Michaël Cadilhac wrote:
> Lennart Borgman <lennart.borgman.073@student.lu.se> writes:
> 
>> I think this test in `report-emacs-bug' tests the wrong mail address:
>>
>>       ;; Insert warnings for novice users.
>>       (when (string-match "@gnu\\.org^" reporting-address)
>> 	(insert "This bug report will be sent to the Free Software Foundation,\n")
>> 	(let ((pos (point)))
>> 	  (insert "not to your local site managers!")
>> 	  (put-text-property pos (point) 'face 'highlight)))
>>
>> Should it not test `user-mail-address' instead?
> 
> Don't think so.  This warning is here to warn the user that the email
> (s)he writes is GOING TO the FSF, not to the local sysadmin.
> 
> Why do you want to test user-mail-address? Maybe something's missing
> in the warning set of emacsbug in your opinion?


Oh, sorry. It is the regexp that is bad I think. It should probably be 
"@gnu\\.org$".

But I noted more strange things in `report-emacs-bug'. There are a lot 
of statements like

     (put-text-property pos (point) 'face 'highlight)

They does not seem to work. If the OBJECT parameter to put-text-property 
is a string it works, but it does not work with (current-buffer) as far 
as I can see.

Re: Bug in emacsbug.el

[Michaël Cadilhac]

[-- Attachment #1.1: Type: text/plain, Size: 1234 bytes --]

Lennart Borgman <lennart.borgman.073@student.lu.se> writes:

>> Lennart Borgman <lennart.borgman.073@student.lu.se> writes:
>>
>>> I think this test in `report-emacs-bug' tests the wrong mail address:
>>>
>>>       ;; Insert warnings for novice users.
>>>       (when (string-match "@gnu\\.org^" reporting-address)

>  It is the regexp that is bad I think. It should probably be
> "@gnu\\.org$".

Of course you are right! :-)

> But I noted more strange things in `report-emacs-bug'. There are a lot
> of statements like
>
>     (put-text-property pos (point) 'face 'highlight)
>
> They does not seem to work.

Well, AFAICT, it works but mail-mode does not seem to allow it. If you
call text-mode after (compose-mail), the highlight will be there (for
whatever reason I don't have the time to investigate).

-- 
/!\ My mail address has changed, please update your files accordingly.
 |      Michaël `Micha' Cadilhac     |   Je veut dire que la loi francaise    |
 |         Epita/LRDE Promo 2007     |           est overwritable par le      |
 |  http://michael.cadilhac.name     |    reglement interieur il me semble.   |
 `--JID: michael.cadilhac@gmail.com--'          -- ElBarto               -  --'

[-- Attachment #1.2: Type: application/pgp-signature, Size: 188 bytes --]

[-- Attachment #2: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: Bug in emacsbug.el

[Lennart Borgman]

Michaël Cadilhac wrote:
> Lennart Borgman <lennart.borgman.073@student.lu.se> writes:
> 
>>> Lennart Borgman <lennart.borgman.073@student.lu.se> writes:
>>>
>>>> I think this test in `report-emacs-bug' tests the wrong mail address:
>>>>
>>>>       ;; Insert warnings for novice users.
>>>>       (when (string-match "@gnu\\.org^" reporting-address)
> 
>>  It is the regexp that is bad I think. It should probably be
>> "@gnu\\.org$".
> 
> Of course you are right! :-)

Could someone with CVS knowledge please fix that little problem?


>> But I noted more strange things in `report-emacs-bug'. There are a lot
>> of statements like
>>
>>     (put-text-property pos (point) 'face 'highlight)
>>
>> They does not seem to work.
> 
> Well, AFAICT, it works but mail-mode does not seem to allow it. If you
> call text-mode after (compose-mail), the highlight will be there (for
> whatever reason I don't have the time to investigate).

I tested in the scratch buffer and got the same result. However after I 
changed the mode to fundamental-mode the above statement worked.

Re: Bug in emacsbug.el

[Miles Bader]

michael@cadilhac.name (Michaël Cadilhac) writes:
>>     (put-text-property pos (point) 'face 'highlight)
>>
>> They does not seem to work.
>
> Well, AFAICT, it works but mail-mode does not seem to allow it. If you
> call text-mode after (compose-mail), the highlight will be there (for
> whatever reason I don't have the time to investigate).

They work, but font-lock (used by mail-mode/message-mode) overrides
such manually-added face properties.

I think the right fix is to change 'face to 'font-lock-face.  That will
make the highlighting work iff font-lock is enabled -- which it is by
default.  [If those highlights are deemed so important that they must be
seen regardless of whether font-lcok is enabled, one could add _both_
'face and 'font-lock-face properties.]

-Miles
-- 
`Cars give people wonderful freedom and increase their opportunities.
 But they also destroy the environment, to an extent so drastic that
 they kill all social life' (from _A Pattern Language_)

Re: Bug in emacsbug.el

[Lennart Borgman]

Miles Bader wrote:
> michael@cadilhac.name (Michaël Cadilhac) writes:
>>>     (put-text-property pos (point) 'face 'highlight)
>>>
>>> They does not seem to work.
>> Well, AFAICT, it works but mail-mode does not seem to allow it. If you
>> call text-mode after (compose-mail), the highlight will be there (for
>> whatever reason I don't have the time to investigate).
> 
> They work, but font-lock (used by mail-mode/message-mode) overrides
> such manually-added face properties.
> 
> I think the right fix is to change 'face to 'font-lock-face.  That will
> make the highlighting work iff font-lock is enabled -- which it is by
> default.  [If those highlights are deemed so important that they must be
> seen regardless of whether font-lcok is enabled, one could add _both_
> 'face and 'font-lock-face properties.]
> 
> -Miles

Would not an overlay be better? I guess that would not conflict with 
font-lock-mode?

Re: Bug in emacsbug.el

[Miles Bader]

Lennart Borgman <lennart.borgman.073@student.lu.se> writes:
> Would not an overlay be better? I guess that would not conflict with
> font-lock-mode?

Why would an overlay be better?  I think conceptually, it's clearly a
text property, and there's an established mechanism for dealing with
this particular case (overlays are also less efficient in general, but
that's proably not an issue in this case).  Indeed, it's arguably a
_feature_ that switching to font-lock-face would make the highlighting
respect font-lock mode, especially now that the latter is on by default.

-Miles
-- 
`Cars give people wonderful freedom and increase their opportunities.
 But they also destroy the environment, to an extent so drastic that
 they kill all social life' (from _A Pattern Language_)

Re: Bug in emacsbug.el

[Lennart Borgman]

Miles Bader wrote:
> Lennart Borgman <lennart.borgman.073@student.lu.se> writes:
>> Would not an overlay be better? I guess that would not conflict with
>> font-lock-mode?
> 
> Why would an overlay be better?  I think conceptually, it's clearly a
> text property, and there's an established mechanism for dealing with
> this particular case (overlays are also less efficient in general, but
> that's proably not an issue in this case).  Indeed, it's arguably a
> _feature_ that switching to font-lock-face would make the highlighting
> respect font-lock mode, especially now that the latter is on by default.
> 
> -Miles

Ok, seems like I misread the node "(elisp) Precalculated Fontification". 
I thought that explicit use of font-lock-face was something that the 
mode fontification could do.

Re: Bug in emacsbug.el

[Miles Bader]

Lennart Borgman <lennart.borgman.073@student.lu.se> writes:
> Ok, seems like I misread the node "(elisp) Precalculated Fontification". 
> I thought that explicit use of font-lock-face was something that the 
> mode fontification could do.

Well of course the mode fontification can use it too, if they wish.
mail/message-mode do not.

-Miles
-- 
"1971 pickup truck; will trade for guns"