From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Miles Bader Newsgroups: gmane.emacs.devel Subject: Re: Fringes again Date: 22 May 2002 10:24:09 +0900 Sender: emacs-devel-admin@gnu.org Message-ID: References: <877klyie6t.fsf@tc-1-100.kawasaki.gol.ne.jp> Reply-To: Miles Bader NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1022030816 11292 127.0.0.1 (22 May 2002 01:26:56 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Wed, 22 May 2002 01:26:56 +0000 (UTC) Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.33 #1 (Debian)) id 17AKu0-0002w1-00 for ; Wed, 22 May 2002 03:26:56 +0200 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 17AL8g-0005X5-00 for ; Wed, 22 May 2002 03:42:07 +0200 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 17AKuH-00041e-00; Tue, 21 May 2002 21:27:13 -0400 Original-Received: from tyo202.gate.nec.co.jp ([210.143.35.52]) by fencepost.gnu.org with smtp (Exim 3.34 #1 (Debian)) id 17AKrQ-0003vr-00; Tue, 21 May 2002 21:24:17 -0400 Original-Received: from mailgate4.nec.co.jp ([10.7.69.195]) by TYO202.gate.nec.co.jp (8.11.6/3.7W01080315) with ESMTP id g4M1OER14353; Wed, 22 May 2002 10:24:14 +0900 (JST) Original-Received: from mailsv4.nec.co.jp (mailgate51.nec.co.jp [10.7.69.190]) by mailgate4.nec.co.jp (8.11.6/3.7W-MAILGATE-NEC) with ESMTP id g4M1ODL00974; Wed, 22 May 2002 10:24:14 +0900 (JST) Original-Received: from mcsss2.ucom.lsi.nec.co.jp ([10.30.114.133]) by mailsv4.nec.co.jp (8.11.6/3.7W-MAILSV4-NEC) with ESMTP id g4M1O9822486; Wed, 22 May 2002 10:24:11 +0900 (JST) Original-Received: from mcspd15.ucom.lsi.nec.co.jp (mcspd15 [10.30.114.174]) by mcsss2.ucom.lsi.nec.co.jp (8.10.2+Sun/3.7Wlsi_mx_6.0) with ESMTP id g4M1O9K03243; Wed, 22 May 2002 10:24:09 +0900 (JST) Original-Received: by mcspd15.ucom.lsi.nec.co.jp (Postfix, from userid 31295) id 82BD43722; Wed, 22 May 2002 10:24:09 +0900 (JST) Original-To: emacs-devel@gnu.org System-Type: i686-pc-linux-gnu Blat: Foop In-Reply-To: Original-Lines: 41 Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.9 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:4266 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:4266 Simon Josefsson writes: > I've now implemented one approach below. It makes the user interface > of fringe.el similar as mouse-avoidance-mode.el. Is this OK? I like that much better. Perhaps `left' and `right' should be called `left-only' and `right-only' to emphasize what they do (when I first looked at the choices, and saw `left', I immediately thought `left what?' -- even though I already knew what to expect!). I also think it would be clearer to use `both' instead of `default', but that would actually be a slight misnomer, since the implemenation actually does just revert to the default, and that might make the name wrong if the default is ever changed. What do you think? > It is consistent with how `toggle-scroll-bar' and `scroll-bar-mode' > already behaves. The docstring and the prompt triggered by invoking > `toggle-fringe' and `fringe-mode' should now be clear. Is this OK, or > can you suggest alternative names? Well, I like the prompting behavior better, and Richard approved the name `toggle-fringe', but I'm not sure the name `toggle-fringe' makes much sense if it doesn't actually `toggle'... :-( One alternative would be to use the name `set-fringe-mode' to set the per-frame fringe style -- this is also consistent with existing practice, e.g., `set-default-font', `set-background-color', etc., and with this name, prompting for a value actually make sense. :-) A last niggling point is that the (interactive ...) prompting code should probably be put into a function, since it's duplicated in two commands now... Thanks, -Miles -- Come now, if we were really planning to harm you, would we be waiting here, beside the path, in the very darkest part of the forest?