From: Miles Bader <miles.bader@necel.com>
To: Andreas Schwab <schwab@suse.de>
Cc: Dan Nicolaescu <dann@ics.uci.edu>,
ams@gnu.org, claus.klingberg@gmail.com, paul.r.ml@gmail.com,
emacs-devel@gnu.org
Subject: Re: vc-git bug with top-level repositories
Date: Wed, 20 Aug 2008 11:22:01 +0900 [thread overview]
Message-ID: <buoiqtw4e9i.fsf@dhapc248.dev.necel.com> (raw)
In-Reply-To: <jehc9ghepg.fsf@sykes.suse.de> (Andreas Schwab's message of "Tue, 19 Aug 2008 23:34:03 +0200")
>> Doing `git rev-parse --git-dir' or `git rev-parse --is-inside-git-dir'
>> isn't that much more of a headache.
>
> That would then have to be run for _every_ file that Emacs is opening.
> The check whether a directory is controlled by a VCS should be as fast
> as possible.
... and it would have to be done for every vcs supported by Emacs...
As Dan says, there's a reason Emacs does it the way it does.
Running (or at least trying to run) 5-6 external programs, for every
file visited, is not a very nice idea, even if the programs are pretty
fast... :-)
I suppose it is true that if Emacs were to use the "run external
programs to check" method, there are probably various optimizations that
could be done -- e.g. only do it once for the first file visited in any
given directory and assume the resulting status holds for subsequent
files in the same directory. However I think such optimizations also
require making various assumptions (in this case, for instance, that the
state won't change), and have their own tradeoffs.
-Miles
--
Discriminate, v.i. To note the particulars in which one person or thing is,
if possible, more objectionable than another.
next prev parent reply other threads:[~2008-08-20 2:22 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-16 9:17 vc-git bug with top-level repositories Alfred M. Szmidt
2008-08-18 14:33 ` Dan Nicolaescu
2008-08-18 16:24 ` Claus
2008-08-18 16:39 ` Dan Nicolaescu
2008-08-18 20:10 ` Claus
2008-08-18 20:31 ` Dan Nicolaescu
2008-08-19 11:01 ` Claus
2008-08-19 12:00 ` Paul R
2008-08-19 16:56 ` Dan Nicolaescu
2008-08-19 20:43 ` Alfred M. Szmidt
2008-08-19 21:34 ` Andreas Schwab
2008-08-20 2:22 ` Miles Bader [this message]
2008-08-20 9:18 ` Paul R
2008-08-19 18:46 ` Eli Zaretskii
2008-08-20 14:34 ` Stefan Monnier
2008-08-20 15:51 ` Eli Zaretskii
[not found] ` <86bpzn4qw2.fsf@lola.quinscape.zz>
2008-08-20 16:11 ` Eli Zaretskii
2008-08-20 22:44 ` Alfred M. Szmidt
2008-08-27 15:21 ` Stefan Monnier
2008-08-27 21:17 ` Alfred M. Szmidt
2008-08-28 2:09 ` Stefan Monnier
2008-08-29 0:40 ` Miles Bader
2008-08-29 14:09 ` Alfred M. Szmidt
2008-08-27 15:24 ` Stefan Monnier
2008-08-27 21:16 ` Alfred M. Szmidt
2008-08-28 2:06 ` Stefan Monnier
[not found] ` <1219912261.8925.63.camel@ubuntu804desktop.localdomain>
[not found] ` <jwvd4jt87g0.fsf-monnier+emacs@gnu.org>
2008-08-28 19:19 ` Mathias Megyei
2008-08-29 20:12 ` Claus
2008-10-25 15:20 ` Stefan Monnier
2008-10-27 12:43 ` Mathias Megyei
2008-08-29 14:05 ` Alfred M. Szmidt
2008-08-29 15:53 ` Stefan Monnier
2008-08-19 20:07 ` Alfred M. Szmidt
2008-08-18 21:05 ` Alfred M. Szmidt
2008-08-18 21:18 ` Dan Nicolaescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=buoiqtw4e9i.fsf@dhapc248.dev.necel.com \
--to=miles.bader@necel.com \
--cc=ams@gnu.org \
--cc=claus.klingberg@gmail.com \
--cc=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
--cc=miles@gnu.org \
--cc=paul.r.ml@gmail.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.