all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Diff faces
@ 2007-10-11 23:59 Juri Linkov
  2007-10-12  1:21 ` Stefan Monnier
  2007-10-12 15:59 ` Richard Stallman
  0 siblings, 2 replies; 17+ messages in thread
From: Juri Linkov @ 2007-10-11 23:59 UTC (permalink / raw)
  To: emacs-devel

Wouldn't it be better to use the same colors for equivalent faces of
ediff, smerge and diff-mode?  So that ediff-fine-diff-B, diff-fine-change
and smerge-refined-change will be the same and so on.

PS: While looking at ediff faces I discovered a bug: trying to get the
description of ediff faces from the Help buffer created by `C-u C-x ='
fails with (wrong-type-argument symbolp "ediff-fine-diff-B").

Ediff puts face names as strings on overlays, but describe-face accepts
only symbols.  The patch below fixes describe-face to not fail on face
name strings.  As for fixing ediff, I don't know whether this is necessary,
since face names as strings are mostly interchangeable with face symbols.
There are only two places in ediff*.el files that call `face-name' to
convert face symbols to strings, so these calls could be removed.

Index: lisp/faces.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/faces.el,v
retrieving revision 1.377
diff -c -r1.377 faces.el
*** lisp/faces.el	21 Sep 2007 07:23:03 -0000	1.377
--- lisp/faces.el	11 Oct 2007 23:59:05 -0000
***************
*** 1285,1290 ****
--- 1285,1291 ----
        (save-excursion
  	(set-buffer standard-output)
  	(dolist (f face)
+ 	  (if (stringp f) (setq f (intern f)))
  	  (insert "Face: " (symbol-name f))
  	  (if (not (facep f))
  	      (insert "   undefined face.\n")

-- 
Juri Linkov
http://www.jurta.org/emacs/

^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2007-10-20 12:51 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-11 23:59 Diff faces Juri Linkov
2007-10-12  1:21 ` Stefan Monnier
2007-10-14 21:30   ` Juri Linkov
2007-10-15 14:36     ` Stefan Monnier
2007-10-15 23:52       ` Juri Linkov
2007-10-16  3:20         ` Stefan Monnier
2007-10-16  4:12       ` Miles Bader
2007-10-19 16:18     ` Stefan Monnier
2007-10-19 20:55       ` Juri Linkov
2007-10-19 23:42         ` Andreas Schwab
2007-10-20  0:16           ` Juri Linkov
2007-10-20 12:51             ` Stefan Monnier
2007-10-20  0:52         ` Stefan Monnier
2007-10-12 15:59 ` Richard Stallman
2007-10-12 19:42   ` Michael Kifer
2007-10-13  6:41     ` Richard Stallman
2007-10-13  6:55       ` Michael Kifer

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.