From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#13078: [PATCH] configure.ac: Cygwin build breaks when path to pkg-tool contains spaces Date: Tue, 04 Dec 2012 20:59:34 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1354672808 20498 80.91.229.3 (5 Dec 2012 02:00:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 5 Dec 2012 02:00:08 +0000 (UTC) Cc: 13078@debbugs.gnu.org To: Josh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 05 03:00:21 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Tg4HX-00013f-8U for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 Dec 2012 03:00:15 +0100 Original-Received: from localhost ([::1]:59386 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tg4HK-0007RV-8f for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Dec 2012 21:00:02 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:45979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tg4HH-0007OJ-HR for bug-gnu-emacs@gnu.org; Tue, 04 Dec 2012 21:00:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tg4HG-0000N1-2r for bug-gnu-emacs@gnu.org; Tue, 04 Dec 2012 20:59:59 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:43645) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tg4HF-0000Mx-RE for bug-gnu-emacs@gnu.org; Tue, 04 Dec 2012 20:59:58 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Tg4HJ-0003W5-SU for bug-gnu-emacs@gnu.org; Tue, 04 Dec 2012 21:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Dec 2012 02:00:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13078 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 13078-submit@debbugs.gnu.org id=B13078.135467278313474 (code B ref 13078); Wed, 05 Dec 2012 02:00:01 +0000 Original-Received: (at 13078) by debbugs.gnu.org; 5 Dec 2012 01:59:43 +0000 Original-Received: from localhost ([127.0.0.1]:53896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tg4H1-0003VG-6w for submit@debbugs.gnu.org; Tue, 04 Dec 2012 20:59:43 -0500 Original-Received: from fencepost.gnu.org ([208.118.235.10]:54114) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tg4Gy-0003V9-St for 13078@debbugs.gnu.org; Tue, 04 Dec 2012 20:59:41 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Tg4Gt-0004Rf-3L; Tue, 04 Dec 2012 20:59:35 -0500 X-Spook: clandestine cracking espionage ANC Hamas Vickie Weaver X-Ran: YM8&^HxY6+UYm=x`bO\5=R[l(s&&.l|[[Y`TL52xxv (josh@foxtail.org's message of "Mon, 3 Dec 2012 20:35:02 -0800") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:67940 Archived-At: Josh wrote: > but the build failed because ./configure was finding a version of > pkg-config whose path contained whitespace. This exposed some quoting > problems in configure.ac, fixed in the patch below. Thanks, see comments below. (I wouldn't be surprised to learn that there are similar problems for other variables.) > --- a/configure.ac > +++ b/configure.ac [...] > - if $PKG_CONFIG --atleast-pkgconfig-version $PKG_CONFIG_MIN_VERSION; then > + if "$PKG_CONFIG" --atleast-pkgconfig-version $PKG_CONFIG_MIN_VERSION; then > AC_MSG_CHECKING(for $2) > > - if $PKG_CONFIG --exists "$2" 2>&AS_MESSAGE_LOG_FD && > + if "$PKG_CONFIG" --exists "$2" 2>&AS_MESSAGE_LOG_FD && > $1_CFLAGS=`$PKG_CONFIG --cflags "$2" 2>&AS_MESSAGE_LOG_FD` && ^^^^^^^^^^^ > $1_LIBS=`$PKG_CONFIG --libs "$2" 2>&AS_MESSAGE_LOG_FD`; then ^^^^^^^^^^^ Surely these (and the --print-errors call) need quoting too? > edit_cflags=" > @@ -2027,7 +2027,7 @@ if test x"$pkg_check_gtk" = xyes; then > AC_DEFINE(USE_GTK, 1, [Define to 1 if using GTK.]) > GTK_OBJ="gtkutil.o $GTK_OBJ" > USE_X_TOOLKIT=none > - if $PKG_CONFIG --atleast-version=2.10 gtk+-2.0; then > + if "$PKG_CONFIG" --atleast-version=2.10 gtk+-2.0; then