From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#50642: 27.2; autoload xref-pulse-momentarily Date: Sat, 18 Sep 2021 03:14:06 +0300 Message-ID: References: <1BC3E278-B041-4D01-AA25-706FD01CD1E7@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40486"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 To: Howard Melman , 50642@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 18 02:15:30 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRO0v-000ANf-Jz for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Sep 2021 02:15:29 +0200 Original-Received: from localhost ([::1]:47420 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRO0t-0003MB-Rm for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Sep 2021 20:15:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRO0U-0003M0-89 for bug-gnu-emacs@gnu.org; Fri, 17 Sep 2021 20:15:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49946) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mRO0U-0005p2-05 for bug-gnu-emacs@gnu.org; Fri, 17 Sep 2021 20:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mRO0T-0001B6-Rf for bug-gnu-emacs@gnu.org; Fri, 17 Sep 2021 20:15:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Sep 2021 00:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50642 X-GNU-PR-Package: emacs Original-Received: via spool by 50642-submit@debbugs.gnu.org id=B50642.16319240574461 (code B ref 50642); Sat, 18 Sep 2021 00:15:01 +0000 Original-Received: (at 50642) by debbugs.gnu.org; 18 Sep 2021 00:14:17 +0000 Original-Received: from localhost ([127.0.0.1]:33259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRNzk-00019s-Og for submit@debbugs.gnu.org; Fri, 17 Sep 2021 20:14:16 -0400 Original-Received: from mail-wr1-f45.google.com ([209.85.221.45]:34367) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRNzh-00019c-NA for 50642@debbugs.gnu.org; Fri, 17 Sep 2021 20:14:14 -0400 Original-Received: by mail-wr1-f45.google.com with SMTP id t8so10728268wri.1 for <50642@debbugs.gnu.org>; Fri, 17 Sep 2021 17:14:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wmsly7TIa1MLZNiufc3C7s7T8NYfbfBUag9FQZEmMbI=; b=fRQ/ppG+K8beLLJWvO0jE0Jn0jtjFGYLGmMonB9gFgEa01VZZwJCfhOq3+O1ViuuCX N+JmsxwS7echH46E1ci1+RBrehNWHg+6CJowQQEogiE3NSpTlGni8+Wf2Aea7NHcLsr+ Heg8qZ70ZoLqCWc9BFEPsbtr8vCwP499qitEiyfB4m6njIO7hAYVK58YLNEp8X01G7QO Uw9rdieaW6akqZb4qTT8edbBWohij7bXYnjhIn6g1YmU6aQ+8B0hgihB3UrOIJt5WIzo mUtkZ9/Pp/6AfxqSdnVnYg9h/83lpMnQdYniyIULK4bkFhpA/ylZUnlWXEuuOS/cZXZ0 lUlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wmsly7TIa1MLZNiufc3C7s7T8NYfbfBUag9FQZEmMbI=; b=N+PR3bsf7A+Z1/Y8r/UwD06MZZs/f8lhTYsoCEhs+H+Nxx0FiTRY22TuxeHW2rhphk GMlzOgFASQELlwLzi/FEH5FawVsKh98kWSV/B/TYxYyeMpHMWxSFo8MQ85REl+7gWk1X bsA91bimcSLbeUOftw8fppHulf531K6JjlwtHjT+guaAifO2eBhOVM8kzVNA1bqwWJyD 4vYl9kGO7CQQGZCUCIhkASZEdhY1GN8B+FVIAALqItKJERchuJYuP0PFFtZ02xiTnAlh +AcrZvYavjPpnJ5RQahNXMGPUnY4OsOVUFjJ23PS+UsyCOt7jqI0vO7O5b5I236hg92n VG5A== X-Gm-Message-State: AOAM530ogY3p2oKqW2hcgTZuOOhUM18yduRKl/TVHe4Q4NHM6dPqt6Yk PeePptC8dRVQ27qYHlA4hrzp7O344N8= X-Google-Smtp-Source: ABdhPJy+KSkE/9Ouf5xe0wEkLBnWuehodo9St/TQi6Ag25WZkRm8VBVKs7UOlvO5YAXSw59UPnkNWg== X-Received: by 2002:a05:6000:1a52:: with SMTP id t18mr14722998wry.21.1631924047905; Fri, 17 Sep 2021 17:14:07 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id j98sm8508712wrj.88.2021.09.17.17.14.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Sep 2021 17:14:07 -0700 (PDT) In-Reply-To: <1BC3E278-B041-4D01-AA25-706FD01CD1E7@gmail.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214591 Archived-At: On 17.09.2021 17:43, Howard Melman wrote: > I'm not sure about this but can xref-pulse-momentarily be > autoloaded? > > I'm using consult and it has a consult-after-jump-hook which > recommends xref-pulse-momentarily as something you may want > to use in it. I set it and xref-after-jump-hook to: > '(reposition-window xref-pulse-momentarily). > > It works great, but if I use consult before xref I get the error: > run-hooks: Symbol's function definition is void: xref-pulse-momentarily > If I add an autoload call myself it does not error. > > I looked but didn't find a more suitable function to use. > It seems like pulse.el should define a function suitable for > use in a hook, but in its absense xref-pulse-momentarily > does seem like the best option (though I couldn't follow its > implementation). Well, um. I don't really mind but xref-pulse-momentarily was designed to pulse after a jump to an xref location. That's why it refers to xref--current-item in its implementation. It does fall back to pulsing the whole line, so I suppose it can be useful in other cases too. But maybe Counsel wants to provide its own version of this function? It can call xref-pulse-momentarily after xref navigations, but maybe do some more useful fallbacks for other commands? I'm not sure which other kinds of jumps consult-after-jump-hook also handles.