From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.help Subject: RE: Bookmarks in EWW Date: Thu, 26 Mar 2020 07:02:05 -0700 (PDT) Message-ID: References: <878sjrfh2m.fsf@mbork.pl> <871rpipzwa.fsf@web.de> <87tv2d3zii.fsf@web.de> <6d3b94ad-c804-47aa-acb0-3ec64159ee50@default> <87h7yb97cu.fsf@web.de> <839f4c63-80be-4944-af06-48b0072c50f5@default> <87d08z93fx.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="116521"; mail-complaints-to="usenet@ciao.gmane.io" Cc: help-gnu-emacs@gnu.org, Stefan Monnier To: Michael Heerdegen Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 26 15:03:28 2020 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jHT6U-000U6n-Sm for geh-help-gnu-emacs@m.gmane-mx.org; Thu, 26 Mar 2020 15:03:26 +0100 Original-Received: from localhost ([::1]:52314 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHT6T-0008Va-TS for geh-help-gnu-emacs@m.gmane-mx.org; Thu, 26 Mar 2020 10:03:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32886) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHT5V-0007rX-Mt for help-gnu-emacs@gnu.org; Thu, 26 Mar 2020 10:02:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jHT5Q-0002Ad-CD for help-gnu-emacs@gnu.org; Thu, 26 Mar 2020 10:02:25 -0400 Original-Received: from userp2130.oracle.com ([156.151.31.86]:44118) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jHT5Q-0002A9-3Q for help-gnu-emacs@gnu.org; Thu, 26 Mar 2020 10:02:20 -0400 Original-Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02QDrFvT127586; Thu, 26 Mar 2020 14:02:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=N9KYYLMUSv9lZiQ5m4jAgXUivRSS4xgLi2nsjNV8Z+4=; b=M1l18mXqYfdK1xtCwvjgPpcXx0NGvKOrNMwyCCSViKI/E0z1dan5mly9UrTb8KPE9uKM VGoWFfmn5iGwsPuUNMbHYm/ZBUid/b9YBBIAbVhPL2AO6YccjC6+qBcnihp6TGJtq2TL oQ/cTbtNwulv8i4Dv/7Sck3pvfwMwSVIj7OaHpptv0hLz9gBLnvk5JIUKMxS5SajQFp9 w6Mam/2+kwEq6/SD7jx15hzqk8gHOffU0EBw+ohX8rOEfAG2rbxbQK7aXGZXYd3acEa2 4Um59AOWsBcwKzcwVa3JtJ85uYTCvx2kTCshR+sIsGZZZwlnFPUgg0MLbibfVa8fNEVj Tw== Original-Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 2ywabrfymb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 26 Mar 2020 14:02:15 +0000 Original-Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02QE1jxp179585; Thu, 26 Mar 2020 14:02:15 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 3003gkwvbd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 26 Mar 2020 14:02:14 +0000 Original-Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 02QE269N012808; Thu, 26 Mar 2020 14:02:06 GMT In-Reply-To: <87d08z93fx.fsf@web.de> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4966.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9571 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=999 bulkscore=0 phishscore=0 adultscore=0 spamscore=0 malwarescore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003260108 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9571 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 phishscore=0 priorityscore=1501 clxscore=1015 adultscore=0 mlxscore=0 mlxlogscore=999 bulkscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003260107 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 156.151.31.86 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:122682 Archived-At: > I meant the other locations where a special > `bookmark-make-record-function' is implemented, e.g. "doc-view". I > only had a quick look but most places don't care the features your code > provides. I didn't want to say your code would not work, I also didn't > want to say that those features aren't useful. But if we add them, we > should add them in a uniform way for all implementations of > `bookmark-make-record-function', not only for eww. This is something I > don't want to do. FWIW - The stuff that's in that make-record function is only for EWW. In Bookmark+, the make-record functions for other kinds of bookmarks don't have such things. They're specifically about renaming the EWW buffer, etc. So no, I don't think such things apply "in a uniform way for all implementations" of a make-record function. They're only for EWW. (BTW, there's nothing about "sessions" in the Bookmark+ code, AFAIK; I haven't understood that part either, of your and Marcin's messages.) There is an Emacs Dev thread about this stuff. See https://lists.gnu.org/archive/html/emacs-devel/2018-04/msg00622.html Note that that thread was started by someone requesting to be able to do, for EWW, some of the kinds of things that Bookmark+ offers. And this part of that thread speaks to the use of EWW "bookmarks" versus regular bookmarks, and to the use of different make-record functions for different kinds of bookmarks: https://lists.gnu.org/archive/html/emacs-devel/2018-04/msg00660.html 'Nuff said. I'm not pushing anyone to use code similar to what I offered. My point is that those particular features were added specifically for use with EWW - they're not Bookmark+ features used for any other kinds of bookmarks. The latter kind of feature I didn't provide the code for here, though such things (e.g. tags) were requested in the original Emacs Dev thread. I didn't provide them in the code I offered here because they do require more of Bookmark+.