From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.devel Subject: Re: Performance issue in project.el Date: Tue, 29 Jun 2021 00:14:57 +1200 Message-ID: References: <20210627212123.xciejcjxrv2rxsra.ref@Ergus> <20210627212123.xciejcjxrv2rxsra@Ergus> <20210628114247.tecbjwareetquj6h@Ergus> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32688"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Orcon Webmail Cc: emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 28 14:21:07 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lxqG9-0008EP-4Q for ged-emacs-devel@m.gmane-mx.org; Mon, 28 Jun 2021 14:21:05 +0200 Original-Received: from localhost ([::1]:40104 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lxqG7-00057A-5G for ged-emacs-devel@m.gmane-mx.org; Mon, 28 Jun 2021 08:21:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53084) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxqAM-0004wV-4X for emacs-devel@gnu.org; Mon, 28 Jun 2021 08:15:07 -0400 Original-Received: from smtp-2.orcon.net.nz ([60.234.4.43]:41595) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxqAJ-0006N9-Q7 for emacs-devel@gnu.org; Mon, 28 Jun 2021 08:15:05 -0400 Original-Received: from [10.253.37.70] (port=31370 helo=webmail.orcon.net.nz) by smtp-2.orcon.net.nz with esmtpa (Exim 4.90_1) (envelope-from ) id 1lxqAD-0005YW-3h; Tue, 29 Jun 2021 00:14:57 +1200 Original-Received: from ip-116-251-162-85.kinect.net.nz ([116.251.162.85]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Tue, 29 Jun 2021 00:14:57 +1200 In-Reply-To: <20210628114247.tecbjwareetquj6h@Ergus> X-Sender: psainty@orcon.net.nz X-GeoIP: -- Received-SPF: pass client-ip=60.234.4.43; envelope-from=psainty@orcon.net.nz; helo=smtp-2.orcon.net.nz X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_40=-0.001, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271063 Archived-At: On 2021-06-28 23:42, Ergus wrote: > After reading the function vc-responsible-backend I can see that it > uses > a mapcar to test the responsible; so all of them are always tested in > every single call every time. It didn't in Emacs 27, but see bug #42966 and commit 2697123933e3 https://debbugs.gnu.org/cgi/bugreport.cgi?bug=42966 commit 2697123933e3ac7ed4e21a6d12746a98ed7fa74a Author: Lars Ingebrigtsen Date: Mon Oct 26 21:10:36 2020 +0100 Make vc-responsible-backend choose the most specific backend * lisp/vc/vc.el (vc-responsible-backend): Search through all the VC backends instead of the first one, and choose the one that's most specific (bug#42966).