* Re: master e087c89b1e: Prevent GTK from setting unreasonable size hints with large menu bars [not found] ` <20220221063110.50C7BC07B76@vcs2.savannah.gnu.org> @ 2022-02-22 8:37 ` Andreas Schwab 2022-02-22 9:58 ` Po Lu 0 siblings, 1 reply; 5+ messages in thread From: Andreas Schwab @ 2022-02-22 8:37 UTC (permalink / raw) To: emacs-devel; +Cc: Po Lu On Feb 21 2022, Po Lu via Mailing list for Emacs changes wrote: > diff --git a/src/gtkutil.h b/src/gtkutil.h > index b74244d84d..f850ecc421 100644 > --- a/src/gtkutil.h > +++ b/src/gtkutil.h > @@ -83,6 +83,10 @@ typedef struct xg_menu_item_cb_data_ > > } xg_menu_item_cb_data; > > +#ifdef HAVE_GTK3 > +G_DECLARE_FINAL_TYPE (EmacsMenuBar, emacs_menu_bar, EMACS, MENU_BAR, GtkMenuBar) > +#endif In file included from xdisp.c:467:0: gtkutil.h:87:70: error: expected ‘)’ before ‘GtkMenuBar’ G_DECLARE_FINAL_TYPE (EmacsMenuBar, emacs_menu_bar, EMACS, MENU_BAR, GtkMenuBar) ^ -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master e087c89b1e: Prevent GTK from setting unreasonable size hints with large menu bars 2022-02-22 8:37 ` master e087c89b1e: Prevent GTK from setting unreasonable size hints with large menu bars Andreas Schwab @ 2022-02-22 9:58 ` Po Lu 2022-02-22 10:29 ` martin rudalics 2022-02-22 10:29 ` Andreas Schwab 0 siblings, 2 replies; 5+ messages in thread From: Po Lu @ 2022-02-22 9:58 UTC (permalink / raw) To: Andreas Schwab; +Cc: emacs-devel Andreas Schwab <schwab@linux-m68k.org> writes: > In file included from xdisp.c:467:0: > gtkutil.h:87:70: error: expected ‘)’ before ‘GtkMenuBar’ > G_DECLARE_FINAL_TYPE (EmacsMenuBar, emacs_menu_bar, EMACS, MENU_BAR, GtkMenuBar) What kind of build is that? PGTK? ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master e087c89b1e: Prevent GTK from setting unreasonable size hints with large menu bars 2022-02-22 9:58 ` Po Lu @ 2022-02-22 10:29 ` martin rudalics 2022-02-22 10:34 ` Po Lu 2022-02-22 10:29 ` Andreas Schwab 1 sibling, 1 reply; 5+ messages in thread From: martin rudalics @ 2022-02-22 10:29 UTC (permalink / raw) To: Po Lu, Andreas Schwab; +Cc: emacs-devel >> In file included from xdisp.c:467:0: >> gtkutil.h:87:70: error: expected ‘)’ before ‘GtkMenuBar’ >> G_DECLARE_FINAL_TYPE (EmacsMenuBar, emacs_menu_bar, EMACS, MENU_BAR, GtkMenuBar) > > What kind of build is that? PGTK? GLib < 2.44, presumably. martin ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master e087c89b1e: Prevent GTK from setting unreasonable size hints with large menu bars 2022-02-22 10:29 ` martin rudalics @ 2022-02-22 10:34 ` Po Lu 0 siblings, 0 replies; 5+ messages in thread From: Po Lu @ 2022-02-22 10:34 UTC (permalink / raw) To: martin rudalics; +Cc: Andreas Schwab, emacs-devel martin rudalics <rudalics@gmx.at> writes: > GLib < 2.44, presumably. Ah, thanks for catching that. It will be fixed. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master e087c89b1e: Prevent GTK from setting unreasonable size hints with large menu bars 2022-02-22 9:58 ` Po Lu 2022-02-22 10:29 ` martin rudalics @ 2022-02-22 10:29 ` Andreas Schwab 1 sibling, 0 replies; 5+ messages in thread From: Andreas Schwab @ 2022-02-22 10:29 UTC (permalink / raw) To: Po Lu; +Cc: emacs-devel On Feb 22 2022, Po Lu wrote: > Andreas Schwab <schwab@linux-m68k.org> writes: > >> In file included from xdisp.c:467:0: >> gtkutil.h:87:70: error: expected ‘)’ before ‘GtkMenuBar’ >> G_DECLARE_FINAL_TYPE (EmacsMenuBar, emacs_menu_bar, EMACS, MENU_BAR, GtkMenuBar) > > What kind of build is that? GTK3. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-02-22 10:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <164542506993.4058.7868718805924451854@vcs2.savannah.gnu.org>
[not found] ` <20220221063110.50C7BC07B76@vcs2.savannah.gnu.org>
2022-02-22 8:37 ` master e087c89b1e: Prevent GTK from setting unreasonable size hints with large menu bars Andreas Schwab
2022-02-22 9:58 ` Po Lu
2022-02-22 10:29 ` martin rudalics
2022-02-22 10:34 ` Po Lu
2022-02-22 10:29 ` Andreas Schwab
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.