From: Drew Adams <drew.adams@oracle.com>
To: Juri Linkov <juri@linkov.net>
Cc: 15839@debbugs.gnu.org
Subject: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily
Date: Sat, 24 Nov 2018 19:14:17 -0800 (PST) [thread overview]
Message-ID: <be6ecb05-2c69-4edb-a3f3-8a9e2c926b15@default> (raw)
In-Reply-To: <8736rqgk6f.fsf@mail.linkov.net>
> > 2. What's more, the lazy highlighting of search hits is even more
> > limited currently. When you scroll to the current limit, there can be
> > lots of search hits that are not highlighted.
> >
> > One of the reasons for scrolling is to see what search hits lie beyond
> > the currently shown text. This is already partly defeated, in that
> > even when you scroll some of the hits are not highlighted. This seems
> > more like a bug, but if the enhancement of #1 is done then it should
> > (it needs to) take care of #2 as well: Whatever text is shown should
> > have all of its search hits highlighted with lazy highlighting.
>
> Drew, do you agree that this your request is implemented now
> with lazy-highlight-buffer, so bug#15839 could be closed?
Not as far as I understand. That #2 is only one point (one
part) of several making up the bug report.
If scrolling forward and backward always shows all search hits
lazy-highlighted, then that one part of the bug would seem to
be fixed.
But that fixed behavior is (needs to be) anyway independent of
any customization of `lazy-highlight-buffer'. So no, the
addition of option `lazy-highlight-buffer' in no way fixes this
bug.
Perhaps some infrastructure that has been added now provides
for a way to fix part of this bug - dunno. By that I mean only
that now Isearch has ways of highlighting more than just a
windowful of the buffer. Dunno whether that is helpful here.
And as I said in the bug report, even for this one part of it
(all visible search hits are not necessarily lazy-highlighted),
the lazy-highlighting needed for scrolling could be limited to
what is actually made visible by scrolling - not the whole
buffer. Dunno whether that is a good optimization to make or
not.
What counts is the user perspective: scrolling should show all
hits highlighted, no matter how far you scroll and no matter
which directions. And to get that behavior a user should not
need to change option `lazy-highlight-buffer'. That option
should have no effect on this behavior, and vice versa.
next prev parent reply other threads:[~2018-11-25 3:14 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 23:02 bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily Drew Adams
2013-11-09 0:57 ` Juri Linkov
2013-11-09 3:09 ` Drew Adams
2013-11-10 13:46 ` Stefan Monnier
2013-11-10 16:52 ` Drew Adams
2013-11-11 19:08 ` Drew Adams
2018-11-24 22:45 ` Juri Linkov
2018-11-25 3:14 ` Drew Adams [this message]
2018-11-25 20:15 ` Juri Linkov
2018-11-26 0:16 ` Drew Adams
2018-11-26 23:35 ` Juri Linkov
2018-11-27 0:49 ` Drew Adams
2018-11-28 0:35 ` Juri Linkov
2018-11-28 15:15 ` Drew Adams
2018-11-28 23:01 ` Juri Linkov
2018-11-29 3:36 ` Drew Adams
2018-11-29 22:23 ` Juri Linkov
2018-11-30 0:27 ` Drew Adams
2018-11-30 7:28 ` Eli Zaretskii
[not found] ` <<83lg5bc9d6.fsf@gnu.org>
2018-11-30 15:33 ` Drew Adams
2018-12-04 0:29 ` Juri Linkov
2018-12-04 14:46 ` Drew Adams
2018-12-04 20:46 ` Drew Adams
2018-12-04 21:38 ` Juri Linkov
2018-12-05 0:32 ` Drew Adams
2018-12-05 23:44 ` Juri Linkov
2018-12-06 1:20 ` Drew Adams
2018-12-05 12:59 ` Michael Heerdegen
2018-12-05 23:49 ` Juri Linkov
2018-12-06 12:15 ` Michael Heerdegen
2018-12-06 23:03 ` Juri Linkov
2018-12-07 12:42 ` Michael Heerdegen
2018-12-08 23:38 ` Juri Linkov
2018-12-09 1:13 ` Michael Heerdegen
2018-12-10 0:21 ` Juri Linkov
2018-12-10 0:58 ` Michael Heerdegen
2018-12-11 0:37 ` Juri Linkov
2018-12-11 18:22 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be6ecb05-2c69-4edb-a3f3-8a9e2c926b15@default \
--to=drew.adams@oracle.com \
--cc=15839@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.