From: Dmitry Gutov <dmitry@gutov.dev>
To: Arthur Miller <arthur.miller@live.com>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: Missing snprintf in ucrt mingw + vc-refresh in find-file hook?
Date: Wed, 14 Feb 2024 05:42:52 +0200 [thread overview]
Message-ID: <be13b557-3ac3-4369-a0e6-6a0326217211@gutov.dev> (raw)
In-Reply-To: <DU2PR02MB101092403D9CAD02B8BA8FEA7964F2@DU2PR02MB10109.eurprd02.prod.outlook.com>
On 14/02/2024 01:10, Arthur Miller wrote:
>> We could try dropping the forced refresh from find-file-hook. Then we'd have a
>> function there that should be called differently, which would just reset the
>> saved backend/status for the file, and the cached value for vc-mode (the
>> mode-line element).
>
> I didn't suggest to rebuild everything :). Just an option to remove the update
> for those who don't want the update (I guess I am the only one).
That's wouldn't be a big rewrite, I think. So far it seems the required
changes would be limited, that's why I outlined the idea.
>> Then, if the user disabled showing the VC state in the mode-line, and doesn't
>> have any other packages installed that use the status, Git won't be called, at
>> least not right away.
>
> It would be one's own responsibility to keep track if it is needed by other
> applicaitons or not. This why I asked, if there is something else than modeline
> that needs this.
>
> I see defcustom declaration fo vc-display-status is changed from what it was in
> 29.2 to what is now in the master. I guess you (or someone) is already planning
> something in this direction? Was it meant that vc-refresh (or something in the
> chain of call) decide to call git or not based on the value of that variable?
> Looks to me like that was the plan, but I don't know the intentions.
The idea behind it was something else: to be able to unify mode-line
elements (from vc and project).
> In case when list of files are checked, one can let-binding vc-display-status
> to nil in vc-refresh (or the responsible one) so to not trigger git?
vc-display-status only affects vc's mode-line element.
>> So I would welcome such an experiment, especially if one is careful to retain
>> support for vc-follow-symlinks.
>>
>> vc-after-save could similarly avoid doing the full refresh until the file's
>> backend/state are requested again.
>
> When they request for the backend state; they could do so asyncrhonously to, by
> starting a timer? The update will not be immideate; run first when Emas is idle,
> if it is just the modeline; but third party apps, if there are such, can be more
> picky.
That's not simpler.
next prev parent reply other threads:[~2024-02-14 3:42 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 10:06 Missing snprintf in ucrt mingw + vc-refresh in find-file hook? Arthur Miller
2024-02-12 13:44 ` Dmitry Gutov
2024-02-12 13:56 ` Arthur Miller
2024-02-12 14:58 ` Dmitry Gutov
2024-02-12 16:49 ` Eli Zaretskii
2024-02-12 18:05 ` Dmitry Gutov
2024-02-12 19:15 ` Eli Zaretskii
2024-02-12 19:25 ` Dmitry Gutov
2024-02-12 19:34 ` Eli Zaretskii
2024-02-13 9:47 ` Arthur Miller
2024-02-13 13:36 ` Eli Zaretskii
2024-02-13 14:30 ` Arthur Miller
2024-02-13 21:26 ` Dmitry Gutov
2024-02-13 23:10 ` Arthur Miller
2024-02-14 3:42 ` Dmitry Gutov [this message]
2024-02-14 21:04 ` Arthur Miller
2024-02-14 22:37 ` Dmitry Gutov
2024-02-15 11:16 ` Arthur Miller
2024-02-14 14:30 ` Eli Zaretskii
2024-02-14 16:36 ` Dmitry Gutov
2024-02-14 16:51 ` Eli Zaretskii
2024-02-14 17:01 ` Dmitry Gutov
2024-02-14 17:29 ` Eli Zaretskii
2024-02-14 21:05 ` Dmitry Gutov
2024-02-12 14:36 ` Eli Zaretskii
2024-02-13 10:44 ` Arthur Miller
2024-02-13 13:13 ` Eli Zaretskii
-- strict thread matches above, loose matches on Subject: below --
2024-02-12 17:37 Angelo Graziosi
2024-02-13 10:49 ` Arthur Miller
2024-02-13 19:00 ` Arthur Miller
2024-02-13 20:01 ` Eli Zaretskii
2024-02-13 22:05 ` Arthur Miller
2024-02-14 14:45 ` Eli Zaretskii
2024-02-14 18:43 ` Arthur Miller
2024-02-13 21:26 ` Angelo Graziosi
2024-02-13 22:09 ` Arthur Miller
2024-02-13 22:21 ` Angelo Graziosi
2024-02-13 22:26 ` Arthur Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be13b557-3ac3-4369-a0e6-6a0326217211@gutov.dev \
--to=dmitry@gutov.dev \
--cc=arthur.miller@live.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.