all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Wolfgang Scherer <Wolfgang.Scherer@gmx.de>, 39380@debbugs.gnu.org
Subject: bug#39380: 26.3: Opening files in vc-dir-mode with differing root and working dir fails
Date: Wed, 5 Feb 2020 18:56:01 +0300	[thread overview]
Message-ID: <bde2830b-70f5-e311-a582-c22f6b2e775d@yandex.ru> (raw)
In-Reply-To: <5c7d9eab-59d1-21c1-c8e5-1c820cb2946b@gmx.de>

On 04.02.2020 19:04, Wolfgang Scherer wrote:
> Reverting de76a167dc09dc695a5acebabb7ab354a6bf556e does not change anything for me.
> 
> I had to revert 06083cf41c473404d246de9b91a0116f38c5485f to restore the correct behavior:
> 
> Author: Dmitry Gutov<dgutov@yandex.ru>
> Date:   Sat Jan 30 06:55:32 2016 +0300
> 
>      Don't pass DIR to 'hg status'
>     
>      * lisp/vc/vc-hg.el (vc-hg-dir-status-files):
>      Don't pass DIR to 'hg status' (bug#22481).

Good catch, thank you. Could you try this patch?

diff --git a/lisp/vc/vc-hg.el b/lisp/vc/vc-hg.el
index c9a2cb412e..a91e1f5ad6 100644
--- a/lisp/vc/vc-hg.el
+++ b/lisp/vc/vc-hg.el
@@ -1352,14 +1352,14 @@ vc-hg-after-dir-status
  ;; Follows vc-exec-after.
  (declare-function vc-set-async-update "vc-dispatcher" (process-buffer))

-(defun vc-hg-dir-status-files (_dir files update-function)
+(defun vc-hg-dir-status-files (dir files update-function)
    ;; XXX: We can't pass DIR directly to 'hg status' because that
    ;; returns all ignored files if FILES is non-nil (bug#22481).
-  ;; If honoring DIR ever becomes important, try using '-I DIR/'.
-  (vc-hg-command (current-buffer) 'async files
-                 "status"
-                 (concat "-mardu" (if files "i"))
-                 "-C")
+  (let ((default-directory dir))
+    (vc-hg-command (current-buffer) 'async files
+                   "status" "re:" "-I" "."
+                   (concat "-mardu" (if files "i"))
+                   "-C"))
    (vc-run-delayed
      (vc-hg-after-dir-status update-function)))






  reply	other threads:[~2020-02-05 15:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-01  0:13 bug#39380: 26.3: Opening files in vc-dir-mode with differing root and working dir fails Wolfgang Scherer
2020-02-01  7:20 ` Dmitry Gutov
2020-02-02 22:35   ` Wolfgang Scherer
2020-02-03 13:11     ` Dmitry Gutov
2020-02-04 16:04       ` Wolfgang Scherer
2020-02-05 15:56         ` Dmitry Gutov [this message]
2020-02-06 13:25           ` Wolfgang Scherer
2020-02-06 13:38             ` Dmitry Gutov
2020-02-07  9:53               ` Eli Zaretskii
2020-02-07 11:03                 ` Dmitry Gutov
2020-02-07 14:00                   ` Eli Zaretskii
2020-02-08  1:20                     ` Dmitry Gutov
2020-02-08  8:04                       ` Eli Zaretskii
2020-02-08  9:36                         ` Dmitry Gutov
2020-02-08 10:11                           ` Eli Zaretskii
2020-02-11 22:36                             ` Dmitry Gutov
2020-02-01  7:20 ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bde2830b-70f5-e311-a582-c22f6b2e775d@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=39380@debbugs.gnu.org \
    --cc=Wolfgang.Scherer@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.