From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#73172: [PATCH] Move to start of current header in diff-{file, hunk}-prev Date: Thu, 19 Sep 2024 23:46:00 +0300 Message-ID: References: <4dbaac34-a1cc-4d4c-839c-bda74001e4b5@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22183"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: Stefan Monnier , 73172@debbugs.gnu.org To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 19 22:47:15 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1srO3V-0005Z4-Tz for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 19 Sep 2024 22:47:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1srO39-0005wQ-Oa; Thu, 19 Sep 2024 16:46:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1srO33-0005wA-Ca for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2024 16:46:46 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1srO33-0005Mi-3S for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2024 16:46:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=swouBHHbOUfqbDVmbAraasxm9Jq5glfdCIwQ2sDOrlU=; b=Ce7NbXSErQjz62JQ3pv+I42JdrKjxNhDoiAIwDG/ZHVblQQejxJZ+B7n4b0eHKjJuskn666w+L8u97qFdJvpMERet5i+iqXRUSFaANax5Pd8aooI6ScI37jsliAIM+bnykvVFgHJTccIwEJ2Q+AjJNzU8LSUMMd3KQ2YC7K6tbUHxNlgrbI+Qz83MZGLw7iyVJscAtxAXAxkHJS0OBR75QNqA5OYFkvPAA62/4zPeM/tbrsK1yd/mAlmH/11jwlJxe6HfpK54A9lf3M3iKiqbks32w/yMOJYjpfWPOmMahyZwmPS1eqZCfVsZf6gKGeVVuZfVsjdqz3V1dRHpWkxuQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1srO3K-0006It-GM for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2024 16:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Sep 2024 20:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73172 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73172-submit@debbugs.gnu.org id=B73172.172677879224169 (code B ref 73172); Thu, 19 Sep 2024 20:47:02 +0000 Original-Received: (at 73172) by debbugs.gnu.org; 19 Sep 2024 20:46:32 +0000 Original-Received: from localhost ([127.0.0.1]:33586 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srO2p-0006Hl-M4 for submit@debbugs.gnu.org; Thu, 19 Sep 2024 16:46:31 -0400 Original-Received: from fout7-smtp.messagingengine.com ([103.168.172.150]:51637) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srO2l-0006HR-R2 for 73172@debbugs.gnu.org; Thu, 19 Sep 2024 16:46:30 -0400 Original-Received: from phl-compute-09.internal (phl-compute-09.phl.internal [10.202.2.49]) by mailfout.phl.internal (Postfix) with ESMTP id 6ED2E138022F; Thu, 19 Sep 2024 16:46:04 -0400 (EDT) Original-Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-09.internal (MEProxy); Thu, 19 Sep 2024 16:46:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1726778764; x=1726865164; bh=swouBHHbOUfqbDVmbAraasxm9Jq5glfdCIwQ2sDOrlU=; b= OVnKMcjzMyvoHZFr13JpGTBrikqU5RnxfTQANf3OfwPXs2P22rJ8qjDIZakgopxJ /uLELQ+BKGXVJyxHGJQWD32wMQrylV/fcBE3XLOPb1rr/KoqIAai0LS4zTXmaA0M S9vXEWn0+eCYXxL3DDauco11r85Ng1M4ISqTlsrW4P3s0sZMYnkfBESslkZ88gIX cVKMWhHNcb2ucC4cnrKHzBW0n/KM5fgtR3UC/32Izgmt19rYgRDKsZAtJve/fKfu CHeucCJGEVMX+p3hYTBSmVhhhrormCqhvn0C6xIFPxvJrRbKLa+IdB0d8LOmr+cV 1RDyNNC6wtxPGvy5FSk5vA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1726778764; x= 1726865164; bh=swouBHHbOUfqbDVmbAraasxm9Jq5glfdCIwQ2sDOrlU=; b=I gXuxq4mmdJ2MkcJKB3yOTcNodAXY84cwCyym9O4MLCEcL00tAvkTpqZkLO0lzv0R RqFTTCpkIgEFt5HI/vbPCFqTC5nfr7Gmk8plCl7v3DNKu8+0qOpT80vywbHnnBqr VgvFzbBKshSB2okApF2P+utJeUB37t5mJfS9reiqwq9e+iXbhhMa+FtjHLxBi2QT V040wyAkrm4l4GlDWpj3fphTg8+XtxzeKBSG1+HK1Qq/mK3Ax4DaiMhJJSv6ACnI 1OOD0PeN948c512bsRr78a5rVfmaQK3DnwItAWQE2xuy8Ra/2CXukEjG6pzANbkv iOV7TS8AxFBdLmd1fiJJA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudeluddgudehgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddv jeenucfhrhhomhepffhmihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrd guvghvqeenucggtffrrghtthgvrhhnpeffieefvdelueektdfgleeigedugfevkeefjeev jeffteffueeuueeghfevieduvdenucffohhmrghinhepghhnuhdrohhrghenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumhhithhrhiesghhu thhovhdruggvvhdpnhgspghrtghpthhtohepfedpmhhouggvpehsmhhtphhouhhtpdhrtg hpthhtohepshgsrghughhhsehjrghnvghsthhrvggvthdrtghomhdprhgtphhtthhopeej fedujedvseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepmhhonhhnihgvrh esihhrohdruhhmohhnthhrvggrlhdrtggr X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 19 Sep 2024 16:46:02 -0400 (EDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292076 Archived-At: On 19/09/2024 21:41, Spencer Baugh wrote: >>> Also discussed here: >>> https://lists.gnu.org/archive/html/help-gnu-emacs/2024-08/msg00367.html >> >> Patch#1 seems unequivocally a good thing (easier code iteration) > > BTW, if we want to go ahead and install that patch on its own, that > would be fine with me. I think we'll wait a week or so for somebody to protest, and install both if nobody does. >> and patch#2 seems good on balance. >> >> It does introduce some backward incompatibility in rare cases where I >> have probably internalized the current behavior already -- for example >> in the vc-print-root-log output pressing 'p' while on the first line >> somewhere between the initial '*' and the end of the date dings with >> "No previous log message", and how will move to bol. >> >> But it might be more consistent anyway, given that the there is no >> ding already if you start out inside the summary text. > > Yes. It's definitely a change in behavior. > > But, if someone has internalized: > > diff-file-prev usually acts like "backward-sexp for files" (it moves > point to the start of the current file), except that if point is in > the header of the first file in the buffer then diff-file-prev does > nothing instead. > > Then I think they'll be happy to be able to discard that knowledge > in favor of: > > diff-file-prev always acts like "backward-sexp for files" (it moves > point to the start of the current file). > > Especially because "does nothing in one weird corner case" is not useful > or deliberate behavior (it's just a bug). Yeah, probably. It kind of indicated "no elements above" right away, which is a tad meaningful, but indeed I struggle to produce a scenario where that would make a big difference.