From: Paul Eggert <eggert@cs.ucla.edu>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: master 3139551: Don’t attempt to modify constant strings
Date: Sun, 17 May 2020 10:10:10 -0700 [thread overview]
Message-ID: <bdac9923-4af5-c032-e9c3-cb3c0f3c2ed5@cs.ucla.edu> (raw)
In-Reply-To: <20162b4a-3527-5c5d-3b7f-fb0e67a70d88@yandex.ru>
On 5/17/20 4:24 AM, Dmitry Gutov wrote:
>> -;; (password-cache-add "test" "foo")
>> +;; (password-cache-add "test" (copy-sequence "foo"))
>> ;; => nil
>
> This seems like a false positive.
It's just a comment. Since there are so many ways that a password cache can be
cleared and clearing means the strings holding passwords need to be mutable, I
thought it better for the comment to reflect good practice.
next prev parent reply other threads:[~2020-05-17 17:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200517052512.20679.37725@vcs0.savannah.gnu.org>
[not found] ` <20200517052513.C95BC20A2C@vcs0.savannah.gnu.org>
2020-05-17 11:22 ` master 3139551: Don’t attempt to modify constant strings Dmitry Gutov
2020-05-17 17:01 ` Paul Eggert
2020-05-17 11:24 ` Dmitry Gutov
2020-05-17 17:10 ` Paul Eggert [this message]
2020-05-17 18:02 ` Dmitry Gutov
2020-05-17 21:36 ` Paul Eggert
2020-05-17 21:54 ` Dmitry Gutov
2020-05-17 23:16 ` Paul Eggert
2020-05-17 23:24 ` Dmitry Gutov
2020-05-18 7:03 ` Andreas Schwab
2020-05-18 22:49 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdac9923-4af5-c032-e9c3-cb3c0f3c2ed5@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.