Re: [PATCH] Keep network security info buffers after use

[Jens Schmidt <jschmidt4gnu@vodafonemail.de>]

On 2023-12-22  12:51, Eli Zaretskii wrote:
>> From: Stefan Kangas <stefankangas@gmail.com>
>> Date: Fri, 22 Dec 2023 02:00:38 -0800
>>
>> Karl Fogel <kfogel@red-bean.com> writes:
>>
>>> What do people think of the attached behavior change?
>>
>> It would be useful, yes.  I'm not bit by this often, but it happened to
>> me this week, and it's pretty frustrating.  The only workaround I know
>> of is to manually type in the information into some other program.
> 
> I agree that it could be useful in some cases.  Andreas suggested a
> special command to show this information -- do you think this would be
> a good solution for this situation?

I share Karl's opinion here that this could be too complex for the
problem at hand.

How about the following variation of Karl's patch, which hopefully
meets his request for simplicity and hopefully also these requests of
yours (as long as you do not count the additional multiple choice
option as something that must be revertable by option):

> It must be optional, probably off by default, and if it's on by
> default, there must be a way to get back old behavior.


diff --git a/lisp/net/nsm.el b/lisp/net/nsm.el
index 09f7ac52537..27107edc1c5 100644
--- a/lisp/net/nsm.el
+++ b/lisp/net/nsm.el
@@ -825,6 +825,7 @@ nsm-query-user
            (?f "forward page" "See next page")
            (?n "next" "Next certificate")
            (?p "previous" "Previous certificate")
+           (?k "keep" "Keep certificate details for further inspection")
            (?q "quit" "Quit details view")))
         (done nil))
     (save-window-excursion
@@ -916,7 +917,28 @@ nsm-query-user
                    (setq cert-index (mod (1- cert-index) (length pems)))
                    (insert (nth cert-index pems))
                    (goto-char (point-min))
-                   (read-only-mode)))))
+                   (read-only-mode)))
+
+                (?k
+                 ;; Keep certificate details.
+                 (let ((bufname
+                        (format "*Certificate Details for %s*"
+                                (nsm-certificate-part
+                                 (plist-get (car certs) :subject) "CN" t)))
+                       begin)
+                   (with-current-buffer (get-buffer-create bufname)
+                     (read-only-mode -1)
+                     (goto-char (point-max))
+                     (setq begin (point))
+                     (dolist (cert certs)
+                       (insert (gnutls-format-certificate
+                                (plist-get cert :pem)))
+                       (ensure-empty-lines 1))
+                     (goto-char begin)
+                     (read-only-mode))
+                   (message "Details appended to buffer %s" bufname)
+                   (sit-for 2)))))
+
             ;; Return the answer.
             (cadr answer))
         (kill-buffer cert-buffer)