From: Paul Eggert <eggert@cs.ucla.edu>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master dfed333: Remove fixnum restriction on some display vars
Date: Thu, 23 May 2019 12:57:54 -0700 [thread overview]
Message-ID: <bca3cfd7-cbed-62f2-e093-855aef3cadd7@cs.ucla.edu> (raw)
In-Reply-To: <jwvef4q6w5w.fsf-monnier+emacs@gnu.org>
On 5/22/19 2:06 PM, Stefan Monnier wrote:
> Rather than convert to bignum, we should either crash or signal
> a `hallelujah` error, depending on whether you think this is due to
> a bug or too a supranatural power.
Crashing would be too strong, as one could then crash Emacs simply via
(setq tab-width (1+ most-positive-fixnum)). For the variables involved
with this patch, there should be no need to crash as it should be OK to
treat bignums as out-of-range fixnums - e.g., a bignum tab-width is
treated as if it were 8, which is how an out-of-range fixnum tab-width
is treated.
I'm not a fan of invoking supernatural powers either....
next prev parent reply other threads:[~2019-05-23 19:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190522202917.27067.49863@vcs0.savannah.gnu.org>
[not found] ` <20190522202920.3CA7920498@vcs0.savannah.gnu.org>
2019-05-22 21:06 ` [Emacs-diffs] master dfed333: Remove fixnum restriction on some display vars Stefan Monnier
2019-05-23 19:57 ` Paul Eggert [this message]
2019-05-24 14:32 ` Stefan Monnier
2019-05-24 20:13 ` Paul Eggert
2019-05-24 20:30 ` Eli Zaretskii
2019-05-24 21:31 ` Paul Eggert
2019-05-25 12:08 ` Stefan Monnier
2019-05-23 13:47 ` Andy Moreton
2019-05-23 20:02 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bca3cfd7-cbed-62f2-e093-855aef3cadd7@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.