bug#35124: 26.1; ada-mode 6.1.0 no longer syntax-highlights package names at end of spec

bug#35124: 26.1; ada-mode 6.1.0 no longer syntax-highlights package names at end of spec

[Ludovic Brenta]

X-Debbugs-CC: ada-mode-users@nongnu.org
Package: emacs, ada-mode
Version: 26.1
Severity: minor

If you load a file consisting of these three lines:

package Foo is
    procedure P;
end Foo;

then the second "Foo" is not syntax-highlighted.  If
you then remove the "procedure P", the second Foo is
highlighted properly.

This micro-bug is triggered only when
wisi-partial-parse-threshold is less than the size of
the buffer (i.e. it is zero).

-- 
Ludovic Brenta.

bug#35124: 26.1; ada-mode 6.1.0 no longer syntax-highlights package names at end of spec

[Stephen Leake]

Ludovic Brenta <ludovic@ludovic-brenta.org> writes:

> If you load a file consisting of these three lines:
>
> package Foo is
>    procedure P;
> end Foo;
>
> then the second "Foo" is not syntax-highlighted.  

I can't reproduce this with this small file; font-lock requests that the
entire buffer be parsed, so it is done correctly. With a larger file, so
the start of the package is farther away than the default font-lock
chunk size, the final package name is not highlighted.

This is because the 'end Foo;' is extra text at the end of the partial
parse, and the error recovery inserts 'begin', leaving a labeled block,
in which the label is not highlighted.

If the name has a '.', then it can't be a block label, and it might be
possible to convince the error recovery to insert "package <identifier>
is begin" instead; I'll work on that.

-- 
-- Stephe

bug#35124: close

[Stephen Leake]

-- 
-- Stephe