From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#20489: 25.0.50; next-error-find-buffer chooses non-current buffer without good reason Date: Tue, 13 Mar 2018 00:08:20 +0200 Message-ID: References: <86wq0q602w.fsf@yandex.ru> <877ev36pmr.fsf@mail.linkov.net> <87sha1nbjy.fsf@mail.linkov.net> <23fd061a-9b83-742a-6083-6d2f090b8f22@yandex.ru> <81d36dbe-f563-187a-ec16-df4b051ae204@yandex.ru> <87efl6smxb.fsf@mail.linkov.net> <87zi3s7r16.fsf@mail.linkov.net> <87vae8u8h2.fsf@mail.linkov.net> <2098d801-3877-d404-f66e-debefc0916b6@yandex.ru> <87po4fy4iy.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1520892665 23692 195.159.176.226 (12 Mar 2018 22:11:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 12 Mar 2018 22:11:05 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Thunderbird/59.0 Cc: 20489@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 12 23:11:01 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1evVen-00060f-54 for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Mar 2018 23:11:01 +0100 Original-Received: from localhost ([::1]:35866 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evVgq-0001eH-1z for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Mar 2018 18:13:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evVcx-0006td-Hb for bug-gnu-emacs@gnu.org; Mon, 12 Mar 2018 18:09:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evVcs-0001K2-EJ for bug-gnu-emacs@gnu.org; Mon, 12 Mar 2018 18:09:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49852) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1evVcs-0001Jx-9A for bug-gnu-emacs@gnu.org; Mon, 12 Mar 2018 18:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1evVcs-0005Gb-4d for bug-gnu-emacs@gnu.org; Mon, 12 Mar 2018 18:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Mar 2018 22:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20489 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20489-submit@debbugs.gnu.org id=B20489.152089251220201 (code B ref 20489); Mon, 12 Mar 2018 22:09:02 +0000 Original-Received: (at 20489) by debbugs.gnu.org; 12 Mar 2018 22:08:32 +0000 Original-Received: from localhost ([127.0.0.1]:57749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1evVcO-0005Fl-2P for submit@debbugs.gnu.org; Mon, 12 Mar 2018 18:08:32 -0400 Original-Received: from mail-wr0-f169.google.com ([209.85.128.169]:35562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1evVcL-0005FW-01 for 20489@debbugs.gnu.org; Mon, 12 Mar 2018 18:08:29 -0400 Original-Received: by mail-wr0-f169.google.com with SMTP id n12so6125770wra.2 for <20489@debbugs.gnu.org>; Mon, 12 Mar 2018 15:08:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TQ8Isxf5qoDvQa1ko/0q9/WvQp9JPdR8epV1nEgdp5w=; b=rXaFs+8RXhtslBbACV226dStGAmoss2iZUYxpwbW0OAPS4zF209NPiR5+ZUbrVJn6Y RY2WYordHie8EyJV5/3tSjwq7J20B5FXIQUEP0E4SnNqxXE4HbpgqEhk7Dn0IoiQlH15 yOCBl+Nk8qM4zhxnJ6GYWPzH5+keBEaeUg6QuZKDUwrRtjZw/ipqcMgr90qQNebO76O6 ubhWeXicpCgNQ+8/QIMh6px5Mpc0+X96GIHnK9KPXV9iJCfo05cMMCtbrmOfdjo1fQyJ EVRzac0XTCJRWKow3Cr/0KdUdjbqTX+bO+Z+rU36Z6cafmtEKFtInc+lFWHkioqVhkJf kWCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TQ8Isxf5qoDvQa1ko/0q9/WvQp9JPdR8epV1nEgdp5w=; b=jLuqdoBnlB1nfwk5afx6a9Ylrigcyg1x1Dm6Mjrvsg3FiSlfewWhgPpoE3mw3zpQeS 9bzHsbcPAGVQg85ue8WfHmDO+MyI2jYMWvx8JoDeqaqrgjOH9P30Byw2hEFuw72KTAoF wTRHlLYiE8addFnHNqd2zyrl2hGKuamqd3Po7yum927pTnGwOFC/0YLNDCJ9EVnkEUQa 0eWxVWIAW7Es+56EWaFuramrivaF7vHLM0C8sG3HtJNfTcN5PMtmRnhHvTs1oBe2YbkC vspxaaFBN9USAH/RN33H65pVQMbdhwWxkK4+43gM/lrOn5T6y9I9lqT/zuW2KCNiS9dM 97PQ== X-Gm-Message-State: AElRT7Hlt8KLma3J7WvR6jU/XAfvIY5ABqR3N+KyQYjbzdYV+3I8pikj g2LIFctaUpZEZGuUlwy3afYrgghS X-Google-Smtp-Source: AG47ELuBpm1wxylVvvd3qr5HEESho9HtlxuVduY3CMXSsolBoYQUzmruu1FsIbaXJ51T2AtdEd0J8g== X-Received: by 10.223.139.199 with SMTP id w7mr7036352wra.219.1520892503018; Mon, 12 Mar 2018 15:08:23 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id b8sm8290217wrf.29.2018.03.12.15.08.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Mar 2018 15:08:22 -0700 (PDT) In-Reply-To: <87po4fy4iy.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144162 Archived-At: On 3/7/18 11:11 PM, Juri Linkov wrote: >> For one thing, next-error-select-buffer doesn't call next-error-hook. >> >> And there are other such places (e.g. like you were saying >> xref--xref-buffer-mode should set next-error-last-buffer similarly). > > 3. And hooks are intended only for user customization. Well, we do use them in the core as well. E.g. in define-globalized-minor-mode. >> Aside from that, why would we want to obscure this piece of logic behind >> a hook? > > Instead of a hook I think it would be fine to define an “advisable” function > like Stefan asked to do for next-error-find-buffer-function to be able > to put advices on it. next-error-find-buffer-function would advise it? How? I don't quite see the design. Also, next-error-save-last-buffer-function might be invoked before next-error-find-buffer-function is ever called. E.g. by compilation-start.