all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Davin Pearson <davin.pearson@gmail.com>
To: help-gnu-emacs@gnu.org
Subject: Re: Crappyness of Emacs Version 24.5.1 defadvice
Date: Tue, 28 Jun 2016 18:48:51 -0700 (PDT)	[thread overview]
Message-ID: <bc3eab4e-4658-4511-9a64-70cae5bef35d@googlegroups.com> (raw)
In-Reply-To: <mailman.239.1467123719.26859.help-gnu-emacs@gnu.org>

On Wednesday, June 29, 2016 at 2:22:01 AM UTC+12, Drew Adams wrote:
> > > The old behavior is preferable so I know which file the advice
> > > is coming from.
> > 
> > Could someone tell me how to get the old behavior back?
> 
> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14734
> ("REGRESSION: defadvice broken wrt doc strings (C-h f)")
> 
> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14070
> ("incorrect doc from `C-h f' when use `defadvice' with `before'")
> 
> This post by Stefan provides the rationale behind the new advice
> system.  (You might want to read the rest of the thread too.)
> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16402#31
> ("Document nadvice.el stuff in Elisp manual before Emacs 24.4")

I tried the following code but it doesn't work.

(advice-add 'describe-mode
            :around 
            #'(lambda () (delete-other-windows) ad-do-it)
            )

Worse still, it brings up the following message when I try C-h f describe-mode RET

:around advice: No documentation

Where do I add the documentation to the advice mechanism?


  parent reply	other threads:[~2016-06-29  1:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-27  5:46 Crappyness of Emacs Version 24.5.1 defadvice Davin Pearson
2016-06-28  5:58 ` Davin Pearson
2016-06-28 11:11   ` Dmitry Gutov
2016-06-28 12:59     ` Michael Heerdegen
2016-06-28 14:21   ` Drew Adams
     [not found]   ` <mailman.239.1467123719.26859.help-gnu-emacs@gnu.org>
2016-06-29  1:48     ` Davin Pearson [this message]
2016-06-29  1:55       ` Michael Heerdegen
     [not found]       ` <mailman.260.1467165391.26859.help-gnu-emacs@gnu.org>
2016-06-29  7:01         ` Davin Pearson
2016-06-29  9:02           ` Alexis
2016-06-29  7:05         ` Davin Pearson
2016-06-30 12:46           ` Michael Heerdegen
     [not found]           ` <mailman.320.1467290787.26859.help-gnu-emacs@gnu.org>
2016-06-30 13:09             ` Joost Kremers
2016-06-30 21:16               ` Michael Heerdegen
2016-06-29 13:54       ` Rémi Vanicat
2016-06-30 12:43         ` Michael Heerdegen
2016-07-01 11:39 ` Fwd: " Andreas Röhler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc3eab4e-4658-4511-9a64-70cae5bef35d@googlegroups.com \
    --to=davin.pearson@gmail.com \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.