Re: master 583995c: GnuTLS HMAC and symmetric cipher support

[Paul Eggert <eggert@cs.ucla.edu>]

Glenn Morris wrote:
>> It's OK, as every cipher other than GNUTLS_CIPHER_NULL has a non-NULL name.
> But it isn't OK. That's what this thread is about.
> GNUTLS_CIPHER_UNKNOWN apparently has a NULL name.

Sorry, I still don't see the problem here. From what I can see, 
GNUTLS_CIPHER_NULL is not a cipher (or to be more precise, it is not a valid 
GnuTLS cipher ID). The code in question:

> const gnutls_cipher_algorithm_t *gciphers = gnutls_cipher_list ();
> for (ptrdiff_t pos = 0; gciphers[pos] != GNUTLS_CIPHER_NULL; pos++)
> {
>   gnutls_cipher_algorithm_t gca = gciphers[pos];
>   Lisp_Object cipher_symbol = intern (gnutls_cipher_get_name (gca));

looks only at GnuTLS cipher IDs returned by gnutls_cipher_list, and 
GNUTLS_CIPHER_UNKNOWN is not one of those cipher IDs.