From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#17388: 24.4.50; REGRESSION: Ediff - 1) wrong face, 2) incorrect diffing Date: Sat, 3 May 2014 07:01:13 -0700 (PDT) Message-ID: References: <> <<87wqe43t55.fsf@rosalinde.fritz.box>> <> <<111c9271-6a23-426e-adb2-ff5520c02806@default>> <<83a9az1hok.fsf@gnu.org>> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1399125755 28261 80.91.229.3 (3 May 2014 14:02:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 3 May 2014 14:02:35 +0000 (UTC) Cc: 17388@debbugs.gnu.org, kifer@cs.stonybrook.edu To: Eli Zaretskii , Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 03 16:02:26 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WgaWG-0001Ep-L5 for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 May 2014 16:02:24 +0200 Original-Received: from localhost ([::1]:49097 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgaWG-0000qO-7W for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 May 2014 10:02:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47379) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgaW4-0000qF-GX for bug-gnu-emacs@gnu.org; Sat, 03 May 2014 10:02:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WgaVu-0004tF-PV for bug-gnu-emacs@gnu.org; Sat, 03 May 2014 10:02:12 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60716) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgaVu-0004t8-MX for bug-gnu-emacs@gnu.org; Sat, 03 May 2014 10:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WgaVu-00022o-3e for bug-gnu-emacs@gnu.org; Sat, 03 May 2014 10:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 May 2014 14:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17388 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17388-submit@debbugs.gnu.org id=B17388.13991256897808 (code B ref 17388); Sat, 03 May 2014 14:02:02 +0000 Original-Received: (at 17388) by debbugs.gnu.org; 3 May 2014 14:01:29 +0000 Original-Received: from localhost ([127.0.0.1]:49834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgaVN-00021r-86 for submit@debbugs.gnu.org; Sat, 03 May 2014 10:01:29 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:50138) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgaVL-00021c-7e for 17388@debbugs.gnu.org; Sat, 03 May 2014 10:01:27 -0400 Original-Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s43E1FwY004580 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 3 May 2014 14:01:16 GMT Original-Received: from userz7021.oracle.com (userz7021.oracle.com [156.151.31.85]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s43E1EYG000531 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Sat, 3 May 2014 14:01:15 GMT Original-Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by userz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s43E1DN4002144; Sat, 3 May 2014 14:01:13 GMT In-Reply-To: <<83a9az1hok.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6691.5000 (x86)] X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:88589 Archived-At: > > There should be EITHER, (a) as previously, NO fine diffs shown for > > other than the current diff OR (b) CORRECT (helpful) fine diffs > > shown for the non-current diffs. >=20 > Ediff's "fine diffs" are word-granular. That is, Ediff breaks each > line into "words", then passes the result to the Diff program for > comparisoon, and reflects the results with different faces. AFAIR, > this has always been that way. OK, so you are saying that Emacs has silently changed to (b) from (a), and the way it does fine diffs corresponds to what is shown. So be it. > > > I see both of these problematic highlightings on GNU/Linux builds fro= m > > > both the trunk (bzr 117042) and the emacs-24 branch (bzr 117049). >=20 > I can confirm that too, but (a) I don't think the 2nd issue > constitutes a "problem" (see above), and (b) it is definitely not a > "REGRESSION", because older Emacsen behaved the same wrt fine diffs > inside a line. It is a change in behavior wrt older Emacsen, which do not show fine diffs within the non-current diffs. Regression or improvement - we can have different opinions. (BTW, I see nothing in NEWS about this behavior change.) But more importantly, "REGRESSION" in the subject line is for the bug report, and #1 is the more serious part: removing diff highlighting from part of a diff gives the impression that that unhighlighted text is not different.