From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#29478: 26.0.90; `C-h k' followed by mouse clicks no longer shows down event Date: Tue, 28 Nov 2017 20:33:00 -0800 (PST) Message-ID: References: <1b3879d6-f14e-47b0-970f-baf09598fcfd@default> <871skjnpd8.fsf@users.sourceforge.net> <20171128221036.GC14868@ACM> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1511930053 8662 195.159.176.226 (29 Nov 2017 04:34:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 29 Nov 2017 04:34:13 +0000 (UTC) Cc: 29478@debbugs.gnu.org To: Alan Mackenzie , Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 29 05:34:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJu4T-0001gZ-Sz for geb-bug-gnu-emacs@m.gmane.org; Wed, 29 Nov 2017 05:34:06 +0100 Original-Received: from localhost ([::1]:41241 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJu4a-00020K-SB for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 Nov 2017 23:34:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44303) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJu4U-0001zl-Rl for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 23:34:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJu4Q-0005v3-Sh for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 23:34:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55087) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eJu4Q-0005up-Ow for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 23:34:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eJu4Q-0008Ve-CU for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 23:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Nov 2017 04:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29478 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 29478-submit@debbugs.gnu.org id=B29478.151192999432657 (code B ref 29478); Wed, 29 Nov 2017 04:34:02 +0000 Original-Received: (at 29478) by debbugs.gnu.org; 29 Nov 2017 04:33:14 +0000 Original-Received: from localhost ([127.0.0.1]:35535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJu3e-0008Uf-KO for submit@debbugs.gnu.org; Tue, 28 Nov 2017 23:33:14 -0500 Original-Received: from userp1040.oracle.com ([156.151.31.81]:30045) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJu3b-0008US-WE for 29478@debbugs.gnu.org; Tue, 28 Nov 2017 23:33:13 -0500 Original-Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id vAT4X3oR019723 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 Nov 2017 04:33:03 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id vAT4X2ra023170 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 Nov 2017 04:33:02 GMT Original-Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id vAT4X1Hq015826; Wed, 29 Nov 2017 04:33:01 GMT In-Reply-To: <20171128221036.GC14868@ACM> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4615.0 (x86)] X-Source-IP: userv0022.oracle.com [156.151.31.74] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140536 Archived-At: > > > The down mouse-button event is no longer listed along with the up > > > event when you use `C-h k' with a click event. Dunno whether this > was > > > by design or is an oversight. >=20 > I think if you press and hold the mouse button for (default) half a > second, when you finally release it, C-h k will report the down mouse > event. At least this is how GPM behaves for me on a Linux tty. Ah yes, thanks. I see that now on MS Windows too. > This seems to make sense, because anything bound to a down mouse > event is going to be something like a drag event, where the mouse > button is held for an extended period of time. Sorry, no, I don't buy that. I mean it's probably true that most such bindings involve dragging. But (1) a user who wants to check what `mouse-N' does won't necessarily use it the same way when checking with `C-h k' as when using it for its real purpose. And (2) the problem with this is that it is not easily discoverable. I've used Emacs for quite a while. OK, I expected both up and down to be documented. But even I would likely never have thought to hold the button pressed for a long time before releasing, just to see what `C-h k' had to tell me. If there is no other solution, then I suppose we could live with this. But in that case it should be called out in NEWS, I think. And if there is a possibility of restoring the longstanding behavior then I think we should first try for that. > > Looks like oversight. Possibly related to Bug#29272. The following > > seems to fix it for me, but I'm having trouble convincing myself that > > it's the right thing... >=20 > > Alan, I believe you've been working on this code recently, any > thoughts? >=20 > That I'm redoing some of the underlying C code after a suboptimal patch > some days ago, and this seems to have some effect on the mouse events > reported for C-h c and C-h k. >=20 > Eli has already reported that the proposed negation of that condition > would break the patch and lead to annoying infinite loops with mouse > events. >=20 > I think this code still may have some way to go before reaching its > final state. Thanks for still taking a look and trying to work this out.