From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#31118: 27.0.50; Can't load/compile websocket in 32bit master Date: Tue, 10 Apr 2018 15:41:17 -0700 Organization: UCLA Computer Science Department Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------C5B54F22A6FA2A584517E3B3" X-Trace: blaine.gmane.org 1523400012 28432 195.159.176.226 (10 Apr 2018 22:40:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 10 Apr 2018 22:40:12 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 Cc: 31118-done@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 11 00:40:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f61vr-0007GH-5Q for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Apr 2018 00:40:07 +0200 Original-Received: from localhost ([::1]:52250 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f61xv-0006e8-JK for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Apr 2018 18:42:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42615) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f61xm-0006ce-Nv for bug-gnu-emacs@gnu.org; Tue, 10 Apr 2018 18:42:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f61xi-0004Mh-Qc for bug-gnu-emacs@gnu.org; Tue, 10 Apr 2018 18:42:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37610) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f61xi-0004MQ-LF for bug-gnu-emacs@gnu.org; Tue, 10 Apr 2018 18:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f61xi-0005Ak-CQ for bug-gnu-emacs@gnu.org; Tue, 10 Apr 2018 18:42:02 -0400 In-Reply-To: Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Apr 2018 22:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 31118 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 31118@debbugs.gnu.org, eggert@cs.ucla.edu, monnier@IRO.UMontreal.CA Original-Received: via spool by 31118-done@debbugs.gnu.org id=D31118.152340008919838 (code D ref 31118); Tue, 10 Apr 2018 22:42:02 +0000 Original-Received: (at 31118-done) by debbugs.gnu.org; 10 Apr 2018 22:41:29 +0000 Original-Received: from localhost ([127.0.0.1]:45507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f61xB-00059s-34 for submit@debbugs.gnu.org; Tue, 10 Apr 2018 18:41:29 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:51276) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f61x9-00059f-KQ for 31118-done@debbugs.gnu.org; Tue, 10 Apr 2018 18:41:28 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id AD69516161E; Tue, 10 Apr 2018 15:41:21 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 6t1hXNJLhCYI; Tue, 10 Apr 2018 15:41:20 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id CE2A71616EF; Tue, 10 Apr 2018 15:41:20 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id L80WhkPfqa4P; Tue, 10 Apr 2018 15:41:20 -0700 (PDT) Original-Received: from [192.168.1.9] (unknown [47.154.30.119]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id AAC9F16161E; Tue, 10 Apr 2018 15:41:20 -0700 (PDT) Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145062 Archived-At: This is a multi-part message in MIME format. --------------C5B54F22A6FA2A584517E3B3 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable I fixed that by installing the attached into ELPA. I can't build ELPA from scratch on master now, for other reasons. The bui= ld=20 fails as follows: In toplevel form: packages/counsel-ebdb/counsel-ebdb.el:29:1:Error: Cannot open load file: = No such=20 file or directory, ebdb make: *** [GNUmakefile:171: packages/counsel-ebdb/counsel-ebdb.elc] Error= 1 Is anybody building ELPA regularly? It looks like not. --------------C5B54F22A6FA2A584517E3B3 Content-Type: text/x-patch; name="0001-Port-websocket-to-bleeding-edge-32-bit-Emacs.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-Port-websocket-to-bleeding-edge-32-bit-Emacs.patch" =46rom 76ee35ef60079bb6053e82e280274204a1b9fc70 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Tue, 10 Apr 2018 15:34:09 -0700 Subject: [PATCH] Port websocket to bleeding-edge 32-bit Emacs Problem reported by Stefan Monnier (Bug#31118). * packages/websocket/websocket.el (websocket-to-bytes): Do not assume that #xffffffff is a valid fixnum. --- packages/websocket/websocket.el | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/packages/websocket/websocket.el b/packages/websocket/websock= et.el index 39a31c359..0533fb378 100644 --- a/packages/websocket/websocket.el +++ b/packages/websocket/websocket.el @@ -234,12 +234,9 @@ approximately 537M long." val nbytes)) (if (=3D nbytes 8) (progn - (let ((hi-32bits (lsh val -32)) - ;; Test for systems that don't have > 32 bits, and - ;; for those systems just return the value. - (low-32bits (if (=3D 0 (expt 2 32)) - val - (logand #xffffffff val)))) + (let* ((hi-32bits (lsh val -32)) + ;; This is just VAL on systems that don't have >=3D 32 bits. + (low-32bits (- val (lsh hi-32bits 32)))) (when (or (> hi-32bits 0) (> (lsh low-32bits -29) 0)) (signal 'websocket-frame-too-large val)) (bindat-pack `((:val vec 2 u32)) --=20 2.14.3 --------------C5B54F22A6FA2A584517E3B3--