all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dmitry@gutov.dev>
To: Andrea Corallo <acorallo@gnu.org>
Cc: Yuan Fu <casouri@gmail.com>, Eli Zaretskii <eliz@gnu.org>,
	emacs-devel@gnu.org
Subject: Re: Use (eval-when-compile 'treesit) to save us from writing declare-function forms
Date: Thu, 12 Dec 2024 02:23:02 +0200	[thread overview]
Message-ID: <bb27916a-ab05-43e9-b772-3974761cff39@gutov.dev> (raw)
In-Reply-To: <yp1ttb9eqo7.fsf@fencepost.gnu.org>

On 12/12/2024 01:38, Andrea Corallo wrote:
> The suggestion of having the C functions defined to nops when
> HAVE_TREE_SITTER is not defined is cleaner in principle, but I think
> there are two downsides:
> 
> - We don't tipically do it this way, so it would be an exception

We also don't typically require a caller to have a 'declare-function' 
for every function they use from a package that they (require ...) already.

> - Also we should do it for all the functions in treesit.c, otherwise we
>    don't solve the original problem of introducing warnings by mistake on
>    non treesit builds.

Sure. All non-static ones anyway.



  reply	other threads:[~2024-12-12  0:23 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-03  6:31 Use (eval-when-compile 'treesit) to save us from writing declare-function forms Yuan Fu
2024-12-03  8:30 ` Andrea Corallo
2024-12-04 18:21   ` Yuan Fu
2024-12-03 13:12 ` Eli Zaretskii
2024-12-04 18:19   ` Yuan Fu
2024-12-04 18:57     ` Eli Zaretskii
2024-12-05  6:25       ` Yuan Fu
2024-12-05  7:07         ` Eli Zaretskii
2024-12-07  1:12           ` Yuan Fu
2024-12-07  7:51             ` Eli Zaretskii
2024-12-07 13:47               ` Stefan Monnier
2024-12-08  6:39                 ` Yuan Fu
2024-12-08  7:20                   ` Eli Zaretskii
2024-12-11 23:28                     ` Andrea Corallo
2024-12-08 15:27                   ` Stefan Monnier
2024-12-09  1:37                     ` Yuan Fu
2024-12-09  2:40                       ` Stefan Monnier
2024-12-11  1:57                         ` Dmitry Gutov
2024-12-13 21:54                           ` Stefan Monnier
2024-12-08 16:01     ` Dmitry Gutov
2024-12-11 23:38       ` Andrea Corallo
2024-12-12  0:23         ` Dmitry Gutov [this message]
2024-12-12  6:05           ` Yuan Fu
2024-12-12  6:43             ` Eli Zaretskii
2024-12-13  5:01               ` Yuan Fu
2024-12-12  6:19           ` Eli Zaretskii
2024-12-12  6:13         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb27916a-ab05-43e9-b772-3974761cff39@gutov.dev \
    --to=dmitry@gutov.dev \
    --cc=acorallo@gnu.org \
    --cc=casouri@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.