From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses Date: Sat, 1 Jun 2024 04:59:53 +0300 Message-ID: References: <269722b9-1dcd-47e5-8f60-e8a2ff273259@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9486"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 71209@debbugs.gnu.org, Randy Taylor To: Noah Peart Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 01 04:01:06 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sDE3N-0002IG-H0 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 01 Jun 2024 04:01:05 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sDE3B-0002Pk-FN; Fri, 31 May 2024 22:00:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDE39-0002Oz-0M for bug-gnu-emacs@gnu.org; Fri, 31 May 2024 22:00:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sDE38-0001AA-Oh for bug-gnu-emacs@gnu.org; Fri, 31 May 2024 22:00:50 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sDE3K-0008Du-2T for bug-gnu-emacs@gnu.org; Fri, 31 May 2024 22:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Jun 2024 02:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71209 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71209-submit@debbugs.gnu.org id=B71209.171720721831549 (code B ref 71209); Sat, 01 Jun 2024 02:01:02 +0000 Original-Received: (at 71209) by debbugs.gnu.org; 1 Jun 2024 02:00:18 +0000 Original-Received: from localhost ([127.0.0.1]:55538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDE2c-0008Cn-30 for submit@debbugs.gnu.org; Fri, 31 May 2024 22:00:18 -0400 Original-Received: from wfhigh4-smtp.messagingengine.com ([64.147.123.155]:53969) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDE2Y-0008CV-Fi for 71209@debbugs.gnu.org; Fri, 31 May 2024 22:00:16 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfhigh.west.internal (Postfix) with ESMTP id 4423018000F9; Fri, 31 May 2024 21:59:57 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 31 May 2024 21:59:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1717207196; x=1717293596; bh=iPCidHidTucyvADXIofIl7jd82da8cGd1GQV32ExABU=; b= QwbgBaiiw3P7WOZyDXi6zvxdbC7wDeONaHiPMKzHsdNqXplZhOFWJu/u5qqvYaI2 8X7l2rrLIoD0dyxJkpc7qb357uJQjwYm/m0rqB41f79NHQN2XZOoI/MUGj7+QeKf d5gvF5cABPhSWh873vDKWSNgteQv87bc4RuZP1mrXZhSLRLmnHHixiaxnBP8TDz0 4jD3AZOfS73X6/dMhJPXsZeaO29X8frkJ1wsgxgIH+FxbjCPBgmYd9XBjbuJkaX0 3ir8ZCApdH5TuOsRZB76Ff92rWo9UBlkNWWxxMOVBq/wtubIFe7u4OM16lSeddJ9 M2NTBmbwxqoDCt2k/PLGTg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1717207196; x= 1717293596; bh=iPCidHidTucyvADXIofIl7jd82da8cGd1GQV32ExABU=; b=X OrWBo8zw0fp6j0ixk8el9Gls5oy5A0Vf2dShyxdbZVJFiSDA/FwJrILWE6+S7e0v Ym52fiZpjsCX7j08NzVe3i6jdum0ylCzeIT9rEGOJvY8mZWmsjxhfVj4nhRqo8q7 eZjCR0Uc92FiKTykJsqimK3k8ZqfjTdy03RfXxgTfdep3ZocySzXaYpwwZtCspSz lV+Io8C6179vUL0i8g011CjehN26RdzC0qlf+BWgU6zvcS0TEI0gqBC/XmG9bzOw /75UvMZ90xvKPYTt2Jrfa3E76hCv8v1Rm2oIUb+q5c/Ru54r9svP9Rr9DkX+54Gl sNC5Vx47VbNqyI3Q/ELhQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdekjedghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepteduleejgeehtefgheegjeekueehvdevieekueeftddvtdevfefhvdevgedu jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 31 May 2024 21:59:54 -0400 (EDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286311 Archived-At: On 01/06/2024 04:56, Noah Peart wrote: > > Only if you set treesit-font-lock-level to 4, right? > > Yea, that's true - I assumed most people(?) do, but I just realized > I hadn't been doing that for years until tree-sitter - and now I've > become obsessive compulsive about my fonts. I imagine most actual users just keep in on the default value. But a lot customize it, of course, to get closer to "VS Code look". Personally, I stay with the default, among other things because most of the level 4 'variable' highlights just take the easy route and highlight all the tokens that haven't been matched by any other existing rule. That doesn't feel useful to me.