From: "Tom Breton (Tehom)" <tehom@panix.com>
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: org-html link building diff
Date: Mon, 26 Apr 2010 15:45:07 -0400 [thread overview]
Message-ID: <badd8eeca4f6c3f85473619609e8c4ac.squirrel@mail.panix.com> (raw)
In-Reply-To: <C635187C-9C34-4972-B6D1-0B48764F6B5A@gmail.com>
> I am sure it does - the export function has grown like cancer in the
> run of years.
> Unfortunately, I right now do not have the time to study this
> carefully enough
> to make sure this does not break anything.
> Tom, maybe you can update the patch to the current master.
Actually, I don't seem to be able to push to the repository.
Unfortch, my machine isn't that great for hosting a public repository,
as the instructions suggest. Is there something I need to do?
Or did you mean, base it on the current version of org? I thought I
had because I had just pulled it.
> Are there any volunteers who can put this patch through the mill? Or
> Tom, maybe
> you first want to implement the other stuff you are thinking about?
That's half-done already;
* Mostly, I made the other branches of `cond' use
`org-html-make-link' too. That's done.
* I'd like to cleanup the test whether to inline images. My first
patch had copied it more or less unchanged from what it was.
Now the bulk of the test is encapsulated in
`org-html-should-inline-p', but I've yet to make the code use it.
* And I'd like to make the two sources of name conversion respect
each other.
* There are now two sources of name conversion:
* The existing code to convert org files which operates if
`org-export-html-link-org-files-as-html' is non-nil.
* This changes url type as well as url path
* org-html-cvt-link-fn, which supports converting via a lookup
table or similar. I need that for org2blog, which posts to a
Blogger-style blog directly from org.
* Presently this does not treat url type.
* (For completeness) And it can not convert the name at all.
* So `org-html-cvt-link-fn' signature may change in the near
future, and I'll probably encapsulate the other conversion, and
then the logic will just be choose one by precedence.
A couple of notes:
* I am taking "to make sure this does not break anything" to heart
and I will write some semblance of a test suite for org-html. I'll
post that soon.
Everybody, please feel free to contribute any tests of the proper
current behavior to it.
* Potential snippage:
* There is a FIXME comment in `org-export-as-html' that's been there
for a long time. I suspect it's been fixed, because I haven't
encountered a problem about not escaping something.
* "FIXME: do we need to unescape here somewhere?"
* I don't believe the code just before the `cond' still adds
anything useful. It seems redundant to other code. But I'd like
to hear from others before I dare snip it out.
That is, the code that begins ";; Make an image out of the
description if that is so wanted"
Tom Breton (Tehom)
next prev parent reply other threads:[~2010-04-26 19:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-18 2:13 org-html link building diff Tom Breton (Tehom)
2010-04-26 5:24 ` Carsten Dominik
2010-04-26 10:03 ` Sebastian Rose
2010-04-26 19:45 ` Tom Breton (Tehom) [this message]
2010-04-27 6:07 ` Carsten Dominik
2010-04-28 3:01 ` Tom Breton (Tehom)
2010-04-28 15:07 ` Carsten Dominik
-- strict thread matches above, loose matches on Subject: below --
2010-04-29 22:24 Tom Breton (Tehom)
2010-05-01 12:01 ` Carsten Dominik
2010-05-15 12:29 ` Carsten Dominik
2010-05-15 21:37 ` Tom Breton (Tehom)
2010-05-16 5:03 ` Carsten Dominik
2010-05-18 0:59 ` Tom Breton (Tehom)
2010-05-18 4:47 ` Carsten Dominik
2010-05-18 12:26 ` Sebastian Rose
2010-05-16 5:20 ` Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=badd8eeca4f6c3f85473619609e8c4ac.squirrel@mail.panix.com \
--to=tehom@panix.com \
--cc=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.