From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: master 8c81818673a 6/7: Tune volatile in read_char Date: Mon, 19 Aug 2024 15:20:26 -0700 Organization: UCLA Computer Science Department Message-ID: References: <172386820621.30556.15409337288904485218@vcs2.savannah.gnu.org> <8634n0y2th.fsf@gnu.org> <87plq4cyuj.fsf@protonmail.com> <861q2ky0tg.fsf@gnu.org> <87le0scxig.fsf@protonmail.com> <86y14swksj.fsf@gnu.org> <871q2kcp0a.fsf@protonmail.com> <86r0akwbuk.fsf@gnu.org> <87wmkcb7ig.fsf@protonmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------2hcCCZSUVjDLGiftUMjcLdAT" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38205"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: Eli Zaretskii , acorallo@gnu.org, emacs-devel@gnu.org, stefankangas@gmail.com To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 20 00:21:26 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sgAkg-0009ni-Cx for ged-emacs-devel@m.gmane-mx.org; Tue, 20 Aug 2024 00:21:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sgAjq-0001IA-W3; Mon, 19 Aug 2024 18:20:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sgAjo-0001Hu-7k for emacs-devel@gnu.org; Mon, 19 Aug 2024 18:20:32 -0400 Original-Received: from mail.cs.ucla.edu ([131.179.128.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sgAjm-0005R2-Ee; Mon, 19 Aug 2024 18:20:31 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 84B313C00E8B0; Mon, 19 Aug 2024 15:20:27 -0700 (PDT) Original-Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id uyGEcD3iTtus; Mon, 19 Aug 2024 15:20:27 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 3B47F3C00E401; Mon, 19 Aug 2024 15:20:27 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 3B47F3C00E401 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1724106027; bh=bp0NHjLXr4zTaToh/MxH7BeHbVer1M/Dl+cimj5lWdQ=; h=Message-ID:Date:MIME-Version:To:From; b=IpexH/ON2phLgbjvDEIKdcSiNsPZswWdwIcdAvtHGFIeNz/bH4OZgGrydDCv+jNBI zgmfhY/Cn4St+ZwaWLzfGM/W4Q71ppuCbYeqCXV3LFMxkiM+hvFOuTuhUxrYdyYegn 174ciyXPX0zKxLpR88QuSewZWGDDhnNDkvR2+MC8BlGC7U6khr3D4AxWAQ9kGTNUZ3 9AGa9IGndh4qngcInIes8PgCY0nsLwXitEf6PZ+t2mTr7y3PzEy+ZdzLqjktNPmOdz LhMCIeoym4j5+58a+bd9v07VugQAF/FX6sBLptE20LN7Jy87/HuqmtBrEWPN3S9cLw kSLnLWBWritSQ== X-Virus-Scanned: amavis at mail.cs.ucla.edu Original-Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id YbmnTcVRm02B; Mon, 19 Aug 2024 15:20:27 -0700 (PDT) Original-Received: from [192.168.254.12] (unknown [47.150.137.250]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 18E5E3C00E8B0; Mon, 19 Aug 2024 15:20:27 -0700 (PDT) Content-Language: en-US In-Reply-To: <87wmkcb7ig.fsf@protonmail.com> Received-SPF: pass client-ip=131.179.128.66; envelope-from=eggert@cs.ucla.edu; helo=mail.cs.ucla.edu X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322947 Archived-At: This is a multi-part message in MIME format. --------------2hcCCZSUVjDLGiftUMjcLdAT Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024-08-19 13:08, Pip Cet wrote: > one can come up with similar examples without a > backward jump, which loop unquittably even in emacs-30 Ouch, in that case this issue happens regardless of the recent 'volatile'-related changes, and we should address the issue regardless of what we do with 'volatile'. Would the attached patch fix the issue in master? It can be tuned further (and obviously needs comments); I'm just trying to see whether I understand the point you're making. This patch affects behavior only if BYTE_CODE_SAFE, because as I understand things we trust bytecode anyway otherwise. --------------2hcCCZSUVjDLGiftUMjcLdAT Content-Type: text/x-patch; charset=UTF-8; name="quitcounter.diff" Content-Disposition: attachment; filename="quitcounter.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL3NyYy9ieXRlY29kZS5jIGIvc3JjL2J5dGVjb2RlLmMKaW5kZXggNDhh MjljMjJkNTUuLmMwMjNmNDUwZDFmIDEwMDY0NAotLS0gYS9zcmMvYnl0ZWNvZGUuYworKysg Yi9zcmMvYnl0ZWNvZGUuYwpAQCAtOTk1LDYgKzk5NSw4IEBAICNkZWZpbmUgREVGSU5FKG5h bWUsIHZhbHVlKSBbbmFtZV0gPSAmJmluc25fICMjIG5hbWUsCiAJCSAgfQogCQlwYyA9IGJ5 dGVzdHJfZGF0YTsKIAkJUFVTSCAoYy0+dmFsKTsKKwkJaWYgKEJZVEVfQ09ERV9TQUZFKQor CQkgIHF1aXRjb3VudGVyICs9ICEgKG9wIDwgMCk7CiAJCWdvdG8gb3BfYnJhbmNoOwogCSAg ICAgIH0KIAo= --------------2hcCCZSUVjDLGiftUMjcLdAT--