all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: "Jan Synáček" <jan.synacek@posteo.org>, 55632@debbugs.gnu.org
Subject: bug#55632: [PATCH] Add new user option project-vc-find-tracked-only
Date: Mon, 30 May 2022 00:41:21 +0300	[thread overview]
Message-ID: <b98f1e4b-c04d-43ef-584d-194d691d8c0d@yandex.ru> (raw)
In-Reply-To: <9e283838-aaa1-345e-bce8-21ee863dbc31@yandex.ru>

On 27.05.2022 16:55, Dmitry Gutov wrote:
> On 25.05.2022 12:08, Jan Synáček wrote:
>> Currently, `project-find-file' always includes untracked files, which is
>> not always the desired behavior. This patch adds a new user option to
>> make only find the actual project files. By default, the variable is set
>> to nil, which means the behavior is not changed.
> 
> Sure, thanks. I'll review this soon-ish.

The patch seems functional, thanks. Should also get you better 
performance, if this is the behavior you prefer.

Regarding the naming and the docstring, though: unlike what the 
defcustom says, it will affect also 'project-find-regexp' (i.e. which 
files get searched by this command), and all other features that 
delegate to 'project-files' internally.

So the docstring could use some generalizing. And consider these two 
options for rename:

   - project-vc-tracked-only (defaulting to nil, like in the patch)
   - project-vc-include-untracked (defaulting to t)

The docstring could say something like:

   When non-nil, the VC project backend includes the untracked files.





  reply	other threads:[~2022-05-29 21:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-25  9:08 bug#55632: [PATCH] Add new user option project-vc-find-tracked-only Jan Synáček
2022-05-27 11:01 ` Lars Ingebrigtsen
2022-05-27 13:55 ` Dmitry Gutov
2022-05-29 21:41   ` Dmitry Gutov [this message]
2022-05-30 11:00     ` jan.synacek
2022-05-31 22:49       ` Dmitry Gutov
2022-06-02 19:01         ` jan.synacek
2022-06-02 19:19           ` Eli Zaretskii
2022-06-02 23:45             ` Dmitry Gutov
2022-06-03  5:44               ` Eli Zaretskii
2022-06-04  0:37                 ` Dmitry Gutov
2022-06-04  6:29                   ` Eli Zaretskii
2022-06-04  9:40                     ` Dmitry Gutov
2022-05-30 10:08   ` jan.synacek
2022-05-31 22:57     ` Dmitry Gutov
2022-06-01 15:21       ` jan.synacek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b98f1e4b-c04d-43ef-584d-194d691d8c0d@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=55632@debbugs.gnu.org \
    --cc=jan.synacek@posteo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.