From: "Andreas Röhler" <andreas.roehler@online.de>
To: emacs-devel@gnu.org
Subject: Re: Emacs 25.0.04: Feature Request: Make called-interactively-p's argument optional
Date: Wed, 6 Jul 2016 08:45:29 +0200 [thread overview]
Message-ID: <b8db990a-dd6f-7540-4610-cda1ae94042f@online.de> (raw)
In-Reply-To: <CA+OMD9iRFijg3uw4FHgWkvNGp2xC-6-mHBYkFDp4+bna+4Y=Lg@mail.gmail.com>
On 06.07.2016 07:03, Robert Weiner wrote:
> On Tue, Jul 5, 2016 at 8:24 PM, Noam Postavsky
> <npostavs@users.sourceforge.net> wrote:
>> The recommended way to test whether the function was called using
>> ‘call-interactively’ is to give it an optional argument
>> ‘print-message’ and use the ‘interactive’ spec to make it
>> non-‘nil’ in interactive calls. Here’s an example:
>>
>> (defun foo (&optional print-message)
>> (interactive "p")
>> (when print-message
>> (message "foo")))
> This makes little sense to me. Every time I have a function that
> needs to test whether it was called interactively you want me to add
> essentially an interactive-flag to its argument signature and then
> never send this argument when called non-interactively since the
> caller won't care and the argument is optional so it will be nil by
> default. Again, why should we name and have to look at an argument to
> the function when the interactive test we want is internal to it.
> This is similar to the argument that we shouldn't have to send the
> default 'interactive argument to called-interactively-p.
>
> I'm with John, let's simplify this. Let's undeprecate
> (interactive-p). Did people actually have problems with that that
> kept coming up? Raman and I seemed to have used it for years without
> encountering any.
>
> And John, if you undeprecate it do you really need a patch or can you
> just change it?
>
> Bob
>
1+
prev parent reply other threads:[~2016-07-06 6:45 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 20:35 Emacs 25.0.04: Feature Request: Make called-interactively-p's argument optional Robert Weiner
2016-06-28 19:09 ` John Wiegley
2016-06-28 20:28 ` Robert Weiner
2016-06-30 16:54 ` Andreas Röhler
2016-06-28 20:29 ` Glenn Morris
2016-06-28 20:46 ` Robert Weiner
2016-06-28 20:51 ` Robert Weiner
2016-06-29 20:02 ` Richard Stallman
2016-06-29 20:54 ` Robert Weiner
2016-06-29 21:19 ` Drew Adams
2016-06-29 21:39 ` Robert Weiner
2016-06-29 21:48 ` Robert Weiner
2016-06-30 23:18 ` Richard Stallman
2016-06-29 21:21 ` Clément Pit--Claudel
2016-06-29 21:52 ` Dmitry Gutov
2016-06-29 22:00 ` Robert Weiner
2016-06-30 2:51 ` raman
2016-06-30 14:25 ` Robert Weiner
2016-06-30 15:30 ` Eli Zaretskii
2016-07-03 18:36 ` Andreas Röhler
2016-07-03 18:56 ` Alan Mackenzie
2016-07-03 19:57 ` Andreas Röhler
2016-07-03 19:31 ` Eli Zaretskii
2016-06-30 15:34 ` raman
2016-07-03 0:10 ` Richard Stallman
2016-07-06 0:09 ` John Wiegley
2016-07-06 0:21 ` Dmitry Gutov
2016-07-06 0:31 ` John Wiegley
2016-07-06 1:46 ` raman
2016-07-06 2:05 ` Dmitry Gutov
2016-07-06 14:49 ` Eli Zaretskii
2016-07-06 15:14 ` raman
2016-07-06 14:48 ` Eli Zaretskii
2016-07-06 15:20 ` Robert Weiner
2016-07-06 0:24 ` Noam Postavsky
2016-07-06 5:03 ` Robert Weiner
2016-07-06 6:45 ` Andreas Röhler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8db990a-dd6f-7540-4610-cda1ae94042f@online.de \
--to=andreas.roehler@online.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.