From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Arnold Schwaighofer" Newsgroups: gmane.emacs.bugs Subject: HEAD: Bug in simple.el/minibuffer.el causing display-completion-list to delete not only word to be completed but everything in file before it Date: Mon, 28 Apr 2008 14:22:25 +0200 Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1209396296 27249 80.91.229.12 (28 Apr 2008 15:24:56 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Apr 2008 15:24:56 +0000 (UTC) To: bug-gnu-emacs@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 28 17:25:23 2008 connect(): Connection refused Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JqVCA-0007mU-GL for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Apr 2008 17:23:10 +0200 Original-Received: from localhost ([127.0.0.1]:35919 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JqVBT-0002nI-JR for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Apr 2008 11:22:27 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JqSNL-0001ib-3D for bug-gnu-emacs@gnu.org; Mon, 28 Apr 2008 08:22:31 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JqSNI-0001hk-PL for bug-gnu-emacs@gnu.org; Mon, 28 Apr 2008 08:22:29 -0400 Original-Received: from [199.232.76.173] (port=44502 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JqSNI-0001hY-He for bug-gnu-emacs@gnu.org; Mon, 28 Apr 2008 08:22:28 -0400 Original-Received: from wf-out-1314.google.com ([209.85.200.169]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JqSNI-0006N4-AE for bug-gnu-emacs@gnu.org; Mon, 28 Apr 2008 08:22:28 -0400 Original-Received: by wf-out-1314.google.com with SMTP id 29so4257841wff.24 for ; Mon, 28 Apr 2008 05:22:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; bh=YZdVOqbkyozHmYZBbSCKidJa/jB8K8QKZcrg4Fl52jY=; b=jPnj1X5JICn9EbcQ7mukCaASPn/wG5ihRziONBqesHY1h0Ap5Ngvo7XAYcz30KgMeqoEpjCoo/f2kz0zpS2pQt51C8opU8MacQcA1SdsWS0NSJINAt+uqLzasx7nTtNrNh9Xwdw7BG/b7G0C+qgxg/xLgx2EWgoQOMFHass3dEA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; b=NpLCdcA/c4k8wlXypOySSP43h7J/DnYVT9Lx5I5LmITpPacPniLbc78MZkso+YTP8rPH3bEqn+3BrqQX+5ygK/h3gQcWhIwzVBdWBpEknJxawxXNEtx2YST0Ik2ssiYNCfyaYwReofe7HBdHY9ITMKkUD9iNET3AIE9wThKelww= Original-Received: by 10.142.201.3 with SMTP id y3mr2000464wff.120.1209385345874; Mon, 28 Apr 2008 05:22:25 -0700 (PDT) Original-Received: by 10.142.97.21 with HTTP; Mon, 28 Apr 2008 05:22:25 -0700 (PDT) Content-Disposition: inline X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-Mailman-Approved-At: Mon, 28 Apr 2008 11:20:10 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:17894 Archived-At: Problem: In current HEAD display-completion-list deletes not only word to be completed but everything in file before it. example: (defun my-complete-test () (interactive) (with-output-to-temp-buffer "*Completions*" (display-completion-list '("test1" "test2" "test345") "test"))) and call that function in a buffer on the word "test" (M-x my-complete-test) with some text preceeding "test". deletes everything before word "test" instead of just replacing it. This also happens when using the complete-tag function :(. My interpretation of the problem :). minibuffer.el: display-completion-list (set (make-local-variable 'completion-base-size) (or (cdr last) 0)) sets completion-base-size to 0 which causes everything to be deleted before the word to be completed. the problem seems to be related to completion-setup-function in simple.el checking for completion-base-size where i believe it should check for completion-all-completions-with-base-size is it possible that it should read: Index: lisp/simple.el =================================================================== RCS file: /sources/emacs/emacs/lisp/simple.el,v retrieving revision 1.924 diff -r1.924 simple.el 5527c5527 < (unless completion-base-size --- > (unless completion-all-completions-with-base-size after applying that patch completion works for me.