From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Clean up a couple of compiler warnings Date: Tue, 23 May 2017 10:36:15 -0700 Organization: UCLA Computer Science Department Message-ID: References: <20170518202450.75747-1-phst@google.com> <7631cb49-7940-7758-9ec3-5530e0ab542e@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1495560991 1965 195.159.176.226 (23 May 2017 17:36:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 23 May 2017 17:36:31 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 To: Philipp Stephani , Philipp Stephani , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 23 19:36:26 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDDjN-0000MT-6z for ged-emacs-devel@m.gmane.org; Tue, 23 May 2017 19:36:25 +0200 Original-Received: from localhost ([::1]:50651 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dDDjS-0002Yz-Qs for ged-emacs-devel@m.gmane.org; Tue, 23 May 2017 13:36:30 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49064) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dDDjL-0002Yt-3H for emacs-devel@gnu.org; Tue, 23 May 2017 13:36:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dDDjI-0002MY-0D for emacs-devel@gnu.org; Tue, 23 May 2017 13:36:23 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:51372) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dDDjH-0002MD-Mi for emacs-devel@gnu.org; Tue, 23 May 2017 13:36:19 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 0F662160077; Tue, 23 May 2017 10:36:17 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id y4bLi31zOTe4; Tue, 23 May 2017 10:36:15 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id BE3BF16007F; Tue, 23 May 2017 10:36:15 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Y7mbGdtnevhS; Tue, 23 May 2017 10:36:15 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 7756E160077; Tue, 23 May 2017 10:36:15 -0700 (PDT) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:215131 Archived-At: On 05/23/2017 03:17 AM, Philipp Stephani wrote: > I haven't tested it, but I'm pretty sure that adding > -Wno-missing-braces should work. I'd feel more comfortable if you tested it and then committed it to master. > it would be more future-proof to explicitly specify -Wno... In my experience it's a waste of time to try to future-proof or to retrofit GCC's warnings, or Clang's for that matter. The warnings are too flaky and are too mutable from one version to the next. At best we can arrange for recent GCC to not warn on a few common configurations. Maybe Clang too, if someone takes the time to do that. > But in practice, at least on Unix-like systems, only GCC and Clang matter Other compilers still matter, I'm afraid. E.g., see , which is currently blocking Emacs release, and which is about Intel's C compiler.