From: Paul Eggert <eggert@cs.ucla.edu>
To: Philipp Stephani <phst@google.com>,
Philipp Stephani <p.stephani2@gmail.com>,
emacs-devel@gnu.org
Subject: Re: [PATCH] Clean up a couple of compiler warnings
Date: Tue, 23 May 2017 10:36:15 -0700 [thread overview]
Message-ID: <b8c50e0e-b44e-115c-f9ba-e747f757beda@cs.ucla.edu> (raw)
In-Reply-To: <CAP-RRPvSi6qZDsf9D24Dth-oYtOPf3nAA2iDPPpbf9uya=0LVA@mail.gmail.com>
On 05/23/2017 03:17 AM, Philipp Stephani wrote:
> I haven't tested it, but I'm pretty sure that adding
> -Wno-missing-braces should work.
I'd feel more comfortable if you tested it and then committed it to master.
> it would be more future-proof to explicitly specify -Wno...
In my experience it's a waste of time to try to future-proof or to
retrofit GCC's warnings, or Clang's for that matter. The warnings are
too flaky and are too mutable from one version to the next. At best we
can arrange for recent GCC to not warn on a few common configurations.
Maybe Clang too, if someone takes the time to do that.
> But in practice, at least on Unix-like systems, only GCC and Clang matter
Other compilers still matter, I'm afraid. E.g., see
<http://bugs.gnu.org/26735>, which is currently blocking Emacs release,
and which is about Intel's C compiler.
next prev parent reply other threads:[~2017-05-23 17:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 20:24 [PATCH] Clean up a couple of compiler warnings Philipp Stephani
2017-05-18 20:40 ` Eli Zaretskii
2017-05-19 3:48 ` Paul Eggert
2017-05-19 6:53 ` Eli Zaretskii
2017-05-19 6:55 ` Paul Eggert
2017-05-19 9:31 ` Philipp Stephani
2017-05-21 6:07 ` Paul Eggert
2017-05-21 20:00 ` Philipp Stephani
2017-05-21 20:33 ` Paul Eggert
2017-05-23 10:17 ` Philipp Stephani
2017-05-23 17:36 ` Paul Eggert [this message]
2017-05-23 19:19 ` Eli Zaretskii
2017-05-23 19:21 ` Philipp Stephani
2017-05-21 20:47 ` Perry E. Metzger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8c50e0e-b44e-115c-f9ba-e747f757beda@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=p.stephani2@gmail.com \
--cc=phst@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.