From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Patches for Emacs 25.2 Date: Sat, 31 Dec 2016 14:32:51 +0300 Message-ID: References: <877f96t9oc.fsf@gmx.de> <837f96xgp5.fsf@gnu.org> <87zim2rtck.fsf@gmx.de> <9181f38b-8d6c-c61e-90b0-d44a9e048c9e@gmail.com> <87wph6qd1d.fsf@gmx.de> <831szexb54.fsf@gnu.org> <83shrtx5dv.fsf@gnu.org> <752ec49c-da5b-bf86-e31d-294c362c04cb@gmail.com> <877f95deig.fsf@gmx.de> <6f656e32-a44c-f874-3290-f47b8828078e@yandex.ru> <87oa1r64vg.fsf@gmx.de> <2d749ac6-636b-14f2-e5a9-dcc0e9ba7541@yandex.ru> <8760nzfunl.fsf@gmx.de> <05d06a0a-e6df-5d54-01bf-7bb9447a2f7e@yandex.ru> <158f0095-926f-2b8e-034c-4a05a1f08175@yandex.ru> <3e723e03-6fff-7500-aa91-e8de73519490@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1483184037 734 195.159.176.226 (31 Dec 2016 11:33:57 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 31 Dec 2016 11:33:57 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0 Cc: Michael Albinus , emacs-devel@gnu.org To: Nikolay Kudryavtsev Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 31 12:33:53 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cNHv3-0007jz-JY for ged-emacs-devel@m.gmane.org; Sat, 31 Dec 2016 12:33:49 +0100 Original-Received: from localhost ([::1]:43496 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cNHv8-0004BS-LT for ged-emacs-devel@m.gmane.org; Sat, 31 Dec 2016 06:33:54 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57258) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cNHuG-0004AG-U9 for emacs-devel@gnu.org; Sat, 31 Dec 2016 06:33:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cNHuD-0006qY-RO for emacs-devel@gnu.org; Sat, 31 Dec 2016 06:33:00 -0500 Original-Received: from mail-lf0-x243.google.com ([2a00:1450:4010:c07::243]:33405) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cNHuD-0006pe-JW for emacs-devel@gnu.org; Sat, 31 Dec 2016 06:32:57 -0500 Original-Received: by mail-lf0-x243.google.com with SMTP id y21so36406675lfa.0 for ; Sat, 31 Dec 2016 03:32:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xK1aukCOlSZFClSntqfDRCvrgQ6PirSYpP/u5ceff28=; b=JGBkeHCCy8jfKEGRDszp6hqEp7/6Ppwwg2t5YdH6Cg84QQvPsUVZ+6RgYMz+BuC3Rc FgBsOvN8w9+wp3WdK3z7T+wXcBynQxvm2j2Q2Y+ZVniUxmtgusDhO5XZPwNc9Z/G37+/ teoehOzVukx1fVs0002ZBCv/KOiQ86cR5IJF7J4paUf32rPhJ5gS6LRKIfgnrZddnMr6 eTeG0YeDU/jV2dGIgQJyLX0mmDeUJhrUh9t5aQFMH7XuKinR96KXteGLnZOtu9UeslR8 qIEo4MX2/fVYdE9+YY+ABBuf0KUihfxthxQLerPipmDrLe4FBbuPvBdp6aUB1I8QDe9b VUqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xK1aukCOlSZFClSntqfDRCvrgQ6PirSYpP/u5ceff28=; b=JjUveDoeCz4JslsFbJINIQqS4SWD8DtSCZrbs5sZQz+mqfflUqYYzL9wWZJn3gOzSG nXdbpZQO8JOgZfrybGWMeAKVUdAsdvELNF5G2SB09tj+xhi0EFB/kTUaKQk94V/qGEk/ HRTphIi1wTSaOietoPr3qvMQRwvQhln0m2wptiL/9NC/0YkYM16CyvyKGNejpK7wxVD2 cl16tRdHXspVBMiyRyGW6ZKJNNm9EFqL3EUxsFUJgeg4lTMpKD/VjWTs4HMKbb5Sg46r lHHMXrU0fXQG/R7xe+8a1hQFIWG01c7AW7qK13FsAn0sOaCH8fLnr/MezoS85CI10mP5 lQKg== X-Gm-Message-State: AIkVDXJpI54heo5hyTqRBElwRuExJE5gA00DGQGwTdAZgXhV6JowL1Qx0vcy/ZgDflLhmA== X-Received: by 10.25.211.134 with SMTP id k128mr18390052lfg.118.1483183976166; Sat, 31 Dec 2016 03:32:56 -0800 (PST) Original-Received: from [192.168.1.174] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id d16sm14705783lfj.14.2016.12.31.03.32.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 31 Dec 2016 03:32:55 -0800 (PST) In-Reply-To: <3e723e03-6fff-7500-aa91-e8de73519490@gmail.com> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211022 Archived-At: On 31.12.2016 07:20, Nikolay Kudryavtsev wrote: > b) Write to that file. Here we need the absolute path. We also extract > some args during writing. Doesn't the master version of vc-git-checkin use the local name for this operation? > With this in mind I don't see how we can get rid of (file-remote-p > msg-file 'localname) other than storing it in a local variable, which is > a questionable improvement. Not rid of it, but compute msg-file as the local name just once. > Note: we cannot use file-local-name here, since it was only introduced > on master. You can inline its definition. It's tiny. > I guess I'm kind of late(again) with the new pretest out, but I really > think this bug is pretty major and worth the effort, though YMMV. I get that it's a real problem, but since you didn't hurry to reply, and nobody else complained about this problem in the meantime, it's probably not too urgent IMHO. Though it's not up to me to decide.