From: Dmitry Gutov <dgutov@yandex.ru>
To: Nikolay Kudryavtsev <nikolay.kudryavtsev@gmail.com>
Cc: Michael Albinus <michael.albinus@gmx.de>, emacs-devel@gnu.org
Subject: Re: Patches for Emacs 25.2
Date: Sat, 31 Dec 2016 14:32:51 +0300 [thread overview]
Message-ID: <b8a77017-ea2c-098a-cef9-5a817ca696b5@yandex.ru> (raw)
In-Reply-To: <3e723e03-6fff-7500-aa91-e8de73519490@gmail.com>
On 31.12.2016 07:20, Nikolay Kudryavtsev wrote:
> b) Write to that file. Here we need the absolute path. We also extract
> some args during writing.
Doesn't the master version of vc-git-checkin use the local name for this
operation?
> With this in mind I don't see how we can get rid of (file-remote-p
> msg-file 'localname) other than storing it in a local variable, which is
> a questionable improvement.
Not rid of it, but compute msg-file as the local name just once.
> Note: we cannot use file-local-name here, since it was only introduced
> on master.
You can inline its definition. It's tiny.
> I guess I'm kind of late(again) with the new pretest out, but I really
> think this bug is pretty major and worth the effort, though YMMV.
I get that it's a real problem, but since you didn't hurry to reply, and
nobody else complained about this problem in the meantime, it's probably
not too urgent IMHO.
Though it's not up to me to decide.
next prev parent reply other threads:[~2016-12-31 11:32 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 7:09 Patches for Emacs 25.2 Michael Albinus
2016-10-18 7:24 ` Eli Zaretskii
2016-10-18 7:47 ` Michael Albinus
2016-10-18 8:09 ` Nikolay Kudryavtsev
2016-10-18 8:25 ` Michael Albinus
2016-10-18 9:24 ` Eli Zaretskii
2016-10-18 11:05 ` Nikolay Kudryavtsev
2016-10-18 11:29 ` Eli Zaretskii
2016-10-18 11:59 ` Nikolay Kudryavtsev
2016-10-18 12:32 ` Michael Albinus
2016-10-18 14:38 ` Eli Zaretskii
2016-11-07 0:08 ` Dmitry Gutov
2016-11-07 9:01 ` Michael Albinus
2016-11-07 9:36 ` Dmitry Gutov
2016-11-07 10:31 ` Michael Albinus
2016-11-07 10:39 ` Dmitry Gutov
2016-11-07 10:58 ` Michael Albinus
2016-11-19 23:03 ` Dmitry Gutov
2016-11-20 15:34 ` file-local-name (was: Patches for Emacs 25.2) Michael Albinus
2016-11-19 23:04 ` Patches for Emacs 25.2 Dmitry Gutov
2016-11-20 8:49 ` Michael Albinus
2016-12-31 4:20 ` Nikolay Kudryavtsev
2016-12-31 11:32 ` Dmitry Gutov [this message]
2016-12-31 11:40 ` Eli Zaretskii
2016-12-31 11:44 ` Dmitry Gutov
2017-01-02 10:21 ` Nikolay Kudryavtsev
2017-01-02 10:32 ` Dmitry Gutov
2017-01-02 12:22 ` Michael Albinus
2017-01-02 18:43 ` Nikolay Kudryavtsev
2017-01-02 18:54 ` Michael Albinus
2017-01-02 19:08 ` Dmitry Gutov
2017-01-02 19:56 ` Michael Albinus
2017-01-02 20:08 ` Dmitry Gutov
2017-01-02 19:54 ` Michael Albinus
2017-01-02 20:52 ` Nikolay Kudryavtsev
2017-01-02 19:13 ` Dmitry Gutov
2016-10-18 9:13 ` Eli Zaretskii
2016-10-18 9:55 ` Michael Albinus
2016-10-18 10:05 ` Eli Zaretskii
2016-10-18 11:24 ` Michael Albinus
2016-10-18 11:30 ` Eli Zaretskii
2016-12-16 0:05 ` Dmitry Gutov
2016-12-16 8:10 ` Eli Zaretskii
2016-12-16 18:33 ` Dmitry Gutov
2016-12-16 21:11 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8a77017-ea2c-098a-cef9-5a817ca696b5@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
--cc=nikolay.kudryavtsev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.