From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#62994: [PATCH v7] Add support for colored and styled underlines on tty frames Date: Mon, 22 Apr 2024 10:35:57 -0700 Message-ID: References: <87pm7x5mxc.fsf@kisara.moe> <87sezeitkj.fsf@kisara.moe> <87sezegra8.fsf@yahoo.com> <86bk626imf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26888"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mohkale@kisara.moe, 62994@debbugs.gnu.org To: Eli Zaretskii , Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 22 19:37:08 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ryxbH-0006nW-Mz for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Apr 2024 19:37:07 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ryxaz-0004AX-75; Mon, 22 Apr 2024 13:36:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ryxax-0004A5-2Z for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2024 13:36:47 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ryxaw-0001fd-7M for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2024 13:36:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ryxbC-0002YO-7M for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2024 13:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Apr 2024 17:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62994 X-GNU-PR-Package: emacs Original-Received: via spool by 62994-submit@debbugs.gnu.org id=B62994.17138073829554 (code B ref 62994); Mon, 22 Apr 2024 17:37:02 +0000 Original-Received: (at 62994) by debbugs.gnu.org; 22 Apr 2024 17:36:22 +0000 Original-Received: from localhost ([127.0.0.1]:46981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryxaY-0002U2-8v for submit@debbugs.gnu.org; Mon, 22 Apr 2024 13:36:22 -0400 Original-Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]:49214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryxaU-0002T1-MI for 62994@debbugs.gnu.org; Mon, 22 Apr 2024 13:36:19 -0400 Original-Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-2a564ca6f67so3893535a91.2 for <62994@debbugs.gnu.org>; Mon, 22 Apr 2024 10:36:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713807357; x=1714412157; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=w2TUOO4RDRRGwnwMSm0BgdP39KqFNsVlCZ4A/LkKCM4=; b=Qgp120jr7U6IOoGO1buIlmsPDY7rNOqa+tc/SktHkKWbvkNFEVJyM+UxtNGbJQO231 feiwpl+guLgGb85AqKYx/QublCrepqqAzigDDGrGwF6w4zOiozzi8V4/VzlOLym5ePu7 H3tDx5HwN4X8DNe79uqtFuzGJLvQrMZK6/UNMYc2a2Dv5EiGbWGZKcXFdEIzwnXlMB11 il4br2bzCfgD9DngXpoWirh4XqUTt2sh0Cy/rtDGtRcm7poN89jxGWNnCRmXhMzSJc0B rHSNzA7/m+thC2MTNV4dB38GlESWn8wq+lR6OIg/DNBEmhrIzI9DF/Vefwy1ukH85R5i c5hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713807357; x=1714412157; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=w2TUOO4RDRRGwnwMSm0BgdP39KqFNsVlCZ4A/LkKCM4=; b=vSDoiiymPwCGV7XQCkyg02QMuYX3bGtXRwO58PFRl6HnulAFH+Fp/pe12Ds+r9WbuL 7c6WVTjm80wNJGbWyWLq/hWQ4cIoDvVh2+dIK1LkYJteTqizZMrjXFezzyJlQ/xgsanG 8kqG9ZcpjE272jEI7RinX6guCfkwqKKbJPvzlTSepLVW+lSNDTxhOHy+neBKw4xvKUR6 fGeXYH5GlSy4sbvP8/ITSMfjwFrPLaWsuNH3SrxZEAVr5G/6yjc/N43uUb90DbU/wymc MGgy2eOXBYQqeLZlN54L0JOuVzWLa29o+PkOwn9hdnLYohR+qIASCPQ0F6Wj47cZ4Fuz oFCA== X-Forwarded-Encrypted: i=1; AJvYcCWkFQxqPbrUlNb0c7aubMZ2iZfR957dXOvNKP7VcZU2E0BrfUPeyF3QoXybf77YRNPNGFqkeEKyd1lMCemxvZv87Og4vgY= X-Gm-Message-State: AOJu0YxlOr2dII3fzOuZBMMZHfuiGna9+3Lw/6RRdceESWAtbLyaQwK5 5SY2Lg3j8M179QzmajqRD6ExFM00S18L/zxbAR3CAkC8pGz6Od8n X-Google-Smtp-Source: AGHT+IG4SC6ytj7thJeUpO7ATO2iAK2bBNmzURW4fhcvSiFxSmp4t3BNppuqBSyyszD9e5FBGloWag== X-Received: by 2002:a17:90a:fb95:b0:2a6:ab52:84a1 with SMTP id cp21-20020a17090afb9500b002a6ab5284a1mr10392563pjb.21.1713807356815; Mon, 22 Apr 2024 10:35:56 -0700 (PDT) Original-Received: from [192.168.1.2] ([76.168.148.233]) by smtp.googlemail.com with ESMTPSA id f9-20020a17090a638900b002a22c8e99afsm8045519pjj.12.2024.04.22.10.35.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Apr 2024 10:35:56 -0700 (PDT) Content-Language: en-US In-Reply-To: <86bk626imf.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283842 Archived-At: On 4/21/2024 11:01 PM, Eli Zaretskii wrote: >> Cc: 62994@debbugs.gnu.org >> Date: Mon, 22 Apr 2024 08:44:15 +0800 >> From: Po Lu via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> This change should be accompanied by like updates to *_draw_glyph_string >> and related functions in the remaining terminal backends. > > I believe Jim Porter wanted to work on that. Jim, have you made any > progress in this matter? I spent some time looking at it, and I have what I think would be a reasonable path forward. Essentially, make a more-generalized form of 'x_draw_underwave' that can draw a tiled 1-bit image for the underline, and then pass the image data in as an argument. That would keep the code duplication to a minimum. I haven't gotten a working implementation of this idea yet though, since I've been very busy with non-Emacs things. If someone else is itching to work on this, go for it. Otherwise, I should have a lot more free time by May.